Page MenuHomePhabricator
Differential D11916

[avalanche] remove StakeSigner class
ClosedPublic
Actions

Authored by PiRK on Sep 6 2022, 10:50.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC8edd99cb9e35: [avalanche] remove StakeSigner class
Summary

This class was introduced for the legacy proof format because the stakes could not be signed before the proof data was complete. With the new proof format, each stake can be signed independently of other stakes, so the ProofBuilder can directly store the SignedStakes

Depends on D11914

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Sep 6 2022, 10:50
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 6 2022, 10:50
PiRK requested review of this revision.Sep 6 2022, 10:50
Harbormaster completed remote builds in B19930: Diff 34819.Sep 6 2022, 11:03
Fabien requested changes to this revision.Sep 6 2022, 12:41
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/avalanche/proof.h
89 ↗(On Diff #34819)

You don't need to make this public, as all you need is a ro reference access to the member

This revision now requires changes to proceed.Sep 6 2022, 12:41
PiRK updated this revision to Diff 34825.Sep 6 2022, 13:44

use accessor method instead of making stake public

Harbormaster completed remote builds in B19935: Diff 34825.Sep 6 2022, 14:12
PiRK added a child revision: D11923: [avalanche] remove proofid from StakeCommitment ctor.Sep 6 2022, 14:58
Fabien accepted this revision.Sep 7 2022, 09:35
This revision is now accepted and ready to land.Sep 7 2022, 09:35
PiRK updated this revision to Diff 34877.Sep 8 2022, 18:19

rebase

Harbormaster completed remote builds in B19967: Diff 34877.Sep 8 2022, 18:35
Closed by commit rABC8edd99cb9e35: [avalanche] remove StakeSigner class (authored by PiRK). · Explain WhySep 8 2022, 19:36
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC8edd99cb9e35: [avalanche] remove StakeSigner class.

Revision Contents
Changeset List

PathSize
src/
avalanche/
18 lines
37 lines
test/
10 lines

Diff 34879

View Options

src/avalanche/proofbuilder.h

Loading...
View Options

src/avalanche/proofbuilder.cpp

Loading...
View Options

src/avalanche/test/util.cpp

Loading...