Differential D11917

[avalanche] Set the quorum minimal stake to a sane default
ClosedPublic
Actions

Authored by Fabien on Sep 6 2022, 11:36.

Details

Reviewers

PiRK
sdulfari

Group Reviewers

Restricted Project

Commits

rABC7d06c7e56388: [avalanche] Set the quorum minimal stake to a sane default

Summary

It used to be 0 to avoid breaking the tests, and 10B XEC when the -avalanche flag is set. This diff defaults it to 10B independently of the flag.

Test Plan

ninja check-extended

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Sep 6 2022, 11:36

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 6 2022, 11:36

Fabien requested review of this revision.Sep 6 2022, 11:36

Fabien added a child revision: D11918: [avalanche] Use sane default for the quorum minimum connected stake ratio.

Harbormaster completed remote builds in B19931: Diff 34820.Sep 6 2022, 11:53

Fabien mentioned this in D11919: [avalanche] Use sane default for the minimum number of nodes that sent compact proofs.Sep 6 2022, 12:47

PiRK accepted this revision.Sep 6 2022, 13:28

This revision is now accepted and ready to land.Sep 6 2022, 13:28

sdulfari accepted this revision.Sep 6 2022, 16:17

Closed by commit rABC7d06c7e56388: [avalanche] Set the quorum minimal stake to a sane default (authored by Fabien). · Explain WhySep 7 2022, 09:48

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC7d06c7e56388: [avalanche] Set the quorum minimal stake to a sane default.

Fabien mentioned this in rABC832aa694f698: [avalanche] Use sane default for the minimum number of nodes that sent compact….Sep 7 2022, 09:57

Revision Contents
Changeset List

Path

Size

src/

avalanche/

avalanche.h

7 lines

test/

init_tests.cpp

18 lines

processor_tests.cpp

3 lines

init.cpp

5 lines

test/

functional/

abc_p2p_avalanche_proof_voting.py

19 lines

abc_p2p_avalanche_voting.py

23 lines

abc_p2p_getavaaddr.py

16 lines

Diff 34843

View Options

src/avalanche/avalanche.h

View Options

src/avalanche/test/init_tests.cpp

View Options

src/avalanche/test/processor_tests.cpp

View Options

src/init.cpp

View Options

test/functional/abc_p2p_avalanche_proof_voting.py

View Options

test/functional/abc_p2p_avalanche_voting.py

View Options

test/functional/abc_p2p_getavaaddr.py

[avalanche] Set the quorum minimal stake to a sane defaultClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 34843

src/avalanche/avalanche.h

src/avalanche/test/init_tests.cpp

src/avalanche/test/processor_tests.cpp

src/init.cpp

test/functional/abc_p2p_avalanche_proof_voting.py

test/functional/abc_p2p_avalanche_voting.py

test/functional/abc_p2p_getavaaddr.py

[avalanche] Set the quorum minimal stake to a sane default
ClosedPublic
Actions

Revision Contents
Changeset List