Page MenuHomePhabricator
Differential D11925

[Cashtab] [p2] Patch fee falc in sendToken
ClosedPublic
Actions

Authored by bytesofman on Sep 6 2022, 17:08.

Details

Reviewers
kieran709
Group Reviewers
Restricted Project
Commits
rABCa9242ebe6215: [Cashtab] [p2] Patch fee falc in sendToken
Summary

T2644

Depends on D11924

Patch ambiguous comment with BCH artifact

Test Plan

Confirm no other instances of bch in the sendToken function

Diff Detail

Repository
rABC Bitcoin ABC
Branch
token-send-patch-2
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 19940
Build 39586: Build Diffcashtab-tests
Build 39585: arc lint + arc unit

Event Timeline

bytesofman created this revision.Sep 6 2022, 17:08
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 6 2022, 17:08
bytesofman requested review of this revision.Sep 6 2022, 17:08
Harbormaster completed remote builds in B19940: Diff 34830.Sep 6 2022, 17:10
bytesofman added a child revision: D11926: [Cashtab] [p3] Patch fee falc in sendToken.Sep 6 2022, 17:11
kieran709 added a subscriber: kieran709.Sep 6 2022, 17:37
kieran709 added inline comments.
web/cashtab/src/hooks/useBCH.js
1008

replace BCH with XEC

kieran709 requested changes to this revision.Sep 6 2022, 17:38
This revision now requires changes to proceed.Sep 6 2022, 17:38
kieran709 accepted this revision.Sep 6 2022, 17:40
This revision is now accepted and ready to land.Sep 6 2022, 17:40
Closed by commit rABCa9242ebe6215: [Cashtab] [p2] Patch fee falc in sendToken (authored by bytesofman). · Explain WhySep 6 2022, 17:47
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABCa9242ebe6215: [Cashtab] [p2] Patch fee falc in sendToken.

Revision Contents
Changeset List

PathSize
web/
cashtab/
src/
hooks/
2 lines

Diff 34830

View Options

web/cashtab/src/hooks/useBCH.js

Loading...