Page MenuHomePhabricator
Differential D11933

[Cashtab] [chronik utxo handling p2] Add a function to split utxos by slp, nonSlp to match current storage model
ClosedPublic
Actions

Authored by bytesofman on Sep 7 2022, 16:48.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABCda4b8c685516: [Cashtab] [chronik utxo handling p2] Add a function to split utxos by slp…
Summary

T2447

Depends on D11928

Add a function to split slp and nonSlp utxos.

With chronik, any token that has an slpToken key is an slp utxo. Function with unit test added.

Test Plan

npm start
Confirm slpUtxos.length + nonSlpUtxos.length in chronikSlpBalancesAndUtxos === chronikUtxos.length
Review new unit test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
chronik-utxo-handling-take2
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 19951
Build 39607: Build Diffcashtab-tests
Build 39606: arc lint + arc unit

Event Timeline

bytesofman created this revision.Sep 7 2022, 16:48
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 7 2022, 16:48
bytesofman requested review of this revision.Sep 7 2022, 16:48
bytesofman updated this revision to Diff 34851.

Adding length check to unit test

Harbormaster completed remote builds in B19950: Diff 34850.Sep 7 2022, 16:51
Harbormaster completed remote builds in B19951: Diff 34851.
bytesofman updated this revision to Diff 34852.Sep 7 2022, 17:17

Need to use typeof !== 'undefined' instead of is in, since chronik returns undefined keys

Harbormaster completed remote builds in B19952: Diff 34852.Sep 7 2022, 17:20
bytesofman added a child revision: D11934: [Cashtab] [chronik utxo handling p3] Add a function to create a preliminary `tokens` wallet state object, before getting token info.Sep 7 2022, 17:33
emack accepted this revision.Sep 8 2022, 01:03
This revision is now accepted and ready to land.Sep 8 2022, 01:03
Closed by commit rABCda4b8c685516: [Cashtab] [chronik utxo handling p2] Add a function to split utxos by slp… (authored by bytesofman). · Explain WhySep 20 2022, 15:27
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABCda4b8c685516: [Cashtab] [chronik utxo handling p2] Add a function to split utxos by slp….

Revision Contents
Changeset List

PathSize
web/
cashtab/
src/
hooks/
9 lines
utils/
__mocks__/
6234 lines
__tests__/
35 lines
29 lines

Diff 34851

View Options

web/cashtab/src/hooks/useWallet.js

Loading...
View Options

web/cashtab/src/utils/__mocks__/chronikUtxos.js

Loading...
View Options

web/cashtab/src/utils/__tests__/chronik.test.js

Loading...
View Options

web/cashtab/src/utils/chronik.js

Loading...