Related to T2633. Initial commit for the xec-web-components library. Changes are planned as the AddressConverter needs more work, including styling and functionality.
Details
Details
- Reviewers
bytesofman - Group Reviewers
Restricted Project
cd web/xec-web-components
npm run storybook
Observe the address converter
Todo when AddressConverter is styled and functions appropriately:
Publish and consume library
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- xec-web-components-lib
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 20102 Build 39891: Build Diff Build 39890: arc lint + arc unit
Event Timeline
Comment Actions
I don't think create react app is the best way to start a components library.
Check this out and see if it's feasible: https://neutrinojs.org/packages/react-components/
For now, just get a diff up that only shows one component. It doesn't have to be a useful component. Just a button or a div is fine.
Let me know any issues you experience with the framework or any reasons you think this neutrino package is not a good place to start.
It's the react recommended toolchain for a components library.
https://reactjs.org/docs/create-a-new-react-app.html
https://reactjs.org/docs/create-a-new-react-app.html#more-flexible-toolchains
https://neutrinojs.org/packages/react-components/
Comment Actions
Responding to review feedback: removed previous version of components library, initialized a neutrinojs react components project.
Comment Actions
- storybook isn't here. That's fine, but it's still in the test plan
- Why no typescript? Is that template not available?
- Why webpack 4 and not 5?
- can these components be installed as an npm depedency and used in a separate app? That's the real goal here, needs to be part of the test plan
Comment Actions
can we add hash160 addresses as part of the conversion tool now that we're fairly entwined with chronik?