Differential D11946

[linter] Always assign a path to arcanist linter messages
ClosedPublic
Actions

Authored by Fabien on Sep 9 2022, 09:15.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC18b3727e05e5: [linter] Always assign a path to arcanist linter messages

Summary

Since PHP 8, NULL will not be implicitely converted to string so every length, compare and similar string operations will fail.

Test Plan

arc lint --everything

Diff Detail

Repository

rABC Bitcoin ABC

Branch

arcanist_nonnull_path

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 19973
Build 39642: Build Diff
Build 39641: arc lint + arc unit

Event Timeline

Fabien created this revision.Sep 9 2022, 09:15

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 9 2022, 09:15

Fabien requested review of this revision.Sep 9 2022, 09:15

Harbormaster completed remote builds in B19973: Diff 34885.Sep 9 2022, 09:15

PiRK accepted this revision.Sep 9 2022, 09:58

This revision is now accepted and ready to land.Sep 9 2022, 09:58

Closed by commit rABC18b3727e05e5: [linter] Always assign a path to arcanist linter messages (authored by Fabien). · Explain WhySep 9 2022, 09:58

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC18b3727e05e5: [linter] Always assign a path to arcanist linter messages.

Revision Contents
Changeset List

Path

Size

arcanist/

linter/

BoostDependenciesLinter.php

1 line

CheckDocLinter.php

2 lines

Diff 34885

View Options

arcanist/linter/BoostDependenciesLinter.php