Paths

Table of Contentst

Differential D11960

[Cashtab] [chronik utxo handling p5] Add support for caching token info to limit chronik API calls to unseen tokens
ClosedPublic
Actions

Authored by bytesofman on Sep 12 2022, 16:34.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCb2bab0a8fc64: [Cashtab] [chronik utxo handling p5] Add support for caching token info to…

Summary

T2447

Depends on D11942

Add support for cached token info.

The finalizeTokenArray function will accept an object, cachedTokenInfoById. This object is scanned to see what token info is already in cache. If token info is in this object, then Cashtab will not make an API call to get it.

cacheTokenInfoById will be added to local storage in a later diff on this stack. For now, the function will work even if it is not provided.

Test Plan

Review unit tests and mocks.
npm start
Send a token tx and confirm tx history and wallet balance update appropriately
Receive a token tx and confirm tx history and wallet balance update appropriately

Diff Detail

Repository

rABC Bitcoin ABC

Branch

chronik-utxo-handling-take2

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 19996
Build 39683: Build Diff	cashtab-tests
Build 39682: arc lint + arc unit

Event Timeline

bytesofman created this revision.Sep 12 2022, 16:34

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 12 2022, 16:34

Adding dev log statements for test plan

Harbormaster completed remote builds in B19996: Diff 34925.Sep 12 2022, 16:37

Harbormaster completed remote builds in B19997: Diff 34926.

bytesofman edited the test plan for this revision. (Show Details)Sep 12 2022, 21:35

bytesofman added a child revision: D11964: [Cashtab] [chronik utxo handling p6] Cache token info in local storage.Sep 12 2022, 22:45

emack accepted this revision.Sep 13 2022, 14:21

This revision is now accepted and ready to land.Sep 13 2022, 14:21

Closed by commit rABCb2bab0a8fc64: [Cashtab] [chronik utxo handling p5] Add support for caching token info to… (authored by bytesofman). · Explain WhySep 20 2022, 15:27

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABCb2bab0a8fc64: [Cashtab] [chronik utxo handling p5] Add support for caching token info to….

Revision Contents
Changeset List

Path

Size

web/

cashtab/

src/

hooks/

7 lines

utils/

__tests__/

chronik.test.js

54 lines

24 lines

Diff 34925

web/cashtab/src/hooks/useWallet.js

Loading...

web/cashtab/src/utils/tests/chronik.test.js

Loading...

web/cashtab/src/utils/chronik.js

Loading...