Page MenuHomePhabricator
Differential D11971

Replace fs::absolute calls with AbsPathJoin calls
ClosedPublic
Actions

Authored by PiRK on Sep 13 2022, 12:27.

Details

Reviewers
sdulfari
Group Reviewers
Restricted Project
Commits
rABC9a1aa2025217: Replace fs::absolute calls with AbsPathJoin calls
Summary

This adds better test coverage and will make it easier in core#20744 to remove our dependency on the two-argument boost::filesystem::absolute() function which does not have a direct equivalent in C++17.

This is a backport of core#20932 [2/2]
https://github.com/bitcoin/bitcoin/pull/20932/commits/da9caa1cedd69702aea44cb44b2fd0a2d6d56916

Depends on D11970

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
12 lines
5 lines
rpc/
10 lines
test/
18 lines
util/
10 lines
wallet/
4 lines
4 lines
3 lines

Diff 34961

View Options

src/fs.h

Loading...
View Options

src/fs.cpp

Loading...
View Options

src/rpc/blockchain.cpp

Loading...
View Options

src/test/fs_tests.cpp

Loading...
View Options

src/util/system.cpp

Loading...
View Options

src/wallet/load.cpp

Loading...
View Options

src/wallet/wallet.cpp

Loading...
View Options

src/wallet/wallettool.cpp

Loading...