Details

Reviewers

sdulfari
Fabien

Group Reviewers

Restricted Project

Commits

rABCdbe76049471b: fs: consistently use fsbridge:: for ifstream / ofstream

Summary

fs: consistently use fsbridge for {i,o}fstream

fs: add missing <cassert> include

This is needed to prevent compilation failures once boost is removed,
however is still correct to include now, and reduces the diff in #20744.

<string> is extracted from the defines because it is used for Windows
and non-Windows code, i.e get_filesystem_error_message().

fs: consistently use fsbridge for fopen()

This is a backport of core#24167

Depends on D11984

Notes:

the psbtoperationsdialog.cpp and fuzz.cpp changes are not applicable due to missing backports
the walletframe.cpp changes are in walletview.cpp because of missing backports (core-gui#399)

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20081
Build 39849: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang · build-bench
Build 39848: arc lint + arc unit

Event Timeline

PiRK created this revision.Sep 13 2022, 13:59

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 13 2022, 13:59

PiRK requested review of this revision.Sep 13 2022, 13:59

teamcity edited the summary of this revision. (Show Details)Sep 13 2022, 13:59

PiRK added a child revision: D11974: refactor: replace boost::filesystem with std::filesystem.Sep 13 2022, 14:01

Harbormaster completed remote builds in B20014: Diff 34944.Sep 13 2022, 14:40

psbtoperationsdialog should be its own backport

This revision now requires changes to proceed.Sep 13 2022, 17:22

drop psbtoperationsdialog

Harbormaster completed remote builds in B20072: Diff 35016.Sep 20 2022, 08:29

The walletframe change is missing (see WalletView::gotoLoadPSBT()).
Also please add a comment in the summary to explain the fuzz and psbt changes are missing backports.

src/qt/sendcoinsdialog.cpp
469 ↗	(On Diff #35016)	are you missing a backport for the binary more here ?

This revision now requires changes to proceed.Sep 20 2022, 09:07

add notes to mention missing backports
apply changes in walletview.cpp (see notes)

Harbormaster completed remote builds in B20077: Diff 35023.Sep 20 2022, 14:35

PiRK added inline comments.Sep 20 2022, 15:00

src/qt/sendcoinsdialog.cpp
469 ↗	(On Diff #35016)	Yes, that would have been D11984. Should I do a partial backport of core-gui#188 for this (without psbtoperationsdialog)? The danger of doing this is that we will likely forget to apply the same fixe to psbtoperationsdialog if we decide to backport it later.