Page MenuHomePhabricator

[Cashtab] [chronik utxo handling p10] chronik token minting
ClosedPublic

Authored by bytesofman on Sep 13 2022, 18:00.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABC969bd16bcce7: [Cashtab] [chronik utxo handling p10] chronik token minting
Summary

T2447

Depends on D11977

Patch token creation function to support new chronik utxo format. Patch qty bug in mint calculation.

Test Plan

npm start
Create a token. Review the tx on block explorer to confirm change, fees, general sanity check.
Inspect tx history and observe correct display of genesis qty.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
chronik-utxo-handling-take2
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 20024
Build 39737: Build Diffcashtab-tests
Build 39736: arc lint + arc unit

Event Timeline

emack requested changes to this revision.Sep 20 2022, 06:12
emack added a subscriber: emack.
emack added inline comments.
web/cashtab/src/components/Home/Tx.js
548

changing this to qtySent now parses to 0 zeros for the genesis tx, which I don't think is expected behaviour

image.png (75×494 px, 6 KB)

whereas the original qtyReceived reference was correctly parsed to the token mint amount in the genesis tx, which makes sense because it's what this wallet is receiving from the genesis tx

image.png (71×469 px, 7 KB)

I think qtySent only makes sense for something like a token burn when you're sending the tokens outbound in the burn action.

This revision now requires changes to proceed.Sep 20 2022, 06:12

Reverting Tx.js change and removing coverage req for unit tests that blocked this change

This revision is now accepted and ready to land.Sep 20 2022, 13:30