[avalanche] Add a way to retrieve proof ids from each pool
AbandonedPublic
Actions

Authored by sdulfari on Sep 20 2022, 19:10.

Details

Reviewers

None

Group Reviewers

Restricted Project

Summary

Builds on D11999 and is currently unused. This will be used to fetch proof ids via RPC.

Test Plan

ninja check

Repository

rABC Bitcoin ABC

Branch

pm-getproofids

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20086
Build 39859: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 39858: arc lint + arc unit

sdulfari requested review of this revision.Sep 20 2022, 19:10

Fixup some comments

Fabien added inline comments.

src/avalanche/peermanager.cpp
560 ↗	(On Diff #35053)	This also raises the question whether the pools should be made public at some point, these functions have no added value.
src/avalanche/peermanager.h
415 ↗	(On Diff #35053)	You might want to define a type for std::unordered_set<ProofId, SaltedProofIdHasher>, it's now used in several places especially in the peer manager

sdulfari planned changes to this revision.Sep 20 2022, 20:56

sdulfari added inline comments.

src/avalanche/peermanager.cpp
560 ↗	(On Diff #35053)	D12062 follows this line of thinking after a small fix up to ProofPool's API in D12050. Followup to D12062 will include cleanup of PeerManager's API such as getConflictingProofCount and getImmatureProofCount which are redundant.