Page MenuHomePhabricator

[Cashtab] [service worker fix p2] install create react app default service worker
ClosedPublic

Authored by bytesofman on Sep 21 2022, 15:48.

Details

Summary

T2684

Depends on D12020

This diff replaces the service worker removed in D12020 with the create react app default service worker.

Test Plan

Review https://create-react-app.dev/docs/making-a-progressive-web-app/

This diff was created by running npx create-react-app my-app --template cra-template-pwa and then copying the relevant service worker files. Confirm that the files match, with the exception that index.js has been modified to register the service worker.

npm start
In the dev console, navigate to 'Application' and 'Service Workers." Note that there is no service worker as the new serviceWorkerRegistration.js disables service workers for localhost.
Navigate to https://632b314c324c805f8240173f--cashtab-local-dev.netlify.app/#/wallet where this app has been deployed at this commit. Note that there is a service worker enabled.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
service-worker-stack
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningweb/cashtab/src/service-worker.js:25SPELL1Possible Spelling Mistake
Warningweb/cashtab/src/service-worker.js:29SPELL1Possible Spelling Mistake
Unit
No Test Coverage
Build Status
Buildable 20105
Build 39897: Build Diffcashtab-tests
Build 39896: arc lint + arc unit

Event Timeline

At first I thought this was some way that create react app tagged the file so it would be easy to determine how widely it was used.

However, arc lint is suggesting literally the exact same word. So this is some kind of a weird issue in our spellchecker.

image.png (409×820 px, 16 KB)

I subsituted 'carried out` to resolve the linter issue.

Tail of the build log:

npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: 'postcss-lab-function@4.2.1',
npm WARN EBADENGINE   required: { node: '^12 || ^14 || >=16' },
npm WARN EBADENGINE   current: { node: 'v15.14.0', npm: '7.7.6' }
npm WARN EBADENGINE }
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: 'postcss-logical@5.0.4',
npm WARN EBADENGINE   required: { node: '^12 || ^14 || >=16' },
npm WARN EBADENGINE   current: { node: 'v15.14.0', npm: '7.7.6' }
npm WARN EBADENGINE }
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: 'postcss-nesting@10.2.0',
npm WARN EBADENGINE   required: { node: '^12 || ^14 || >=16' },
npm WARN EBADENGINE   current: { node: 'v15.14.0', npm: '7.7.6' }
npm WARN EBADENGINE }
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: 'postcss-opacity-percentage@1.1.2',
npm WARN EBADENGINE   required: { node: '^12 || ^14 || >=16' },
npm WARN EBADENGINE   current: { node: 'v15.14.0', npm: '7.7.6' }
npm WARN EBADENGINE }
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: 'postcss-overflow-shorthand@3.0.4',
npm WARN EBADENGINE   required: { node: '^12 || ^14 || >=16' },
npm WARN EBADENGINE   current: { node: 'v15.14.0', npm: '7.7.6' }
npm WARN EBADENGINE }
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: 'postcss-place@7.0.5',
npm WARN EBADENGINE   required: { node: '^12 || ^14 || >=16' },
npm WARN EBADENGINE   current: { node: 'v15.14.0', npm: '7.7.6' }
npm WARN EBADENGINE }
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: 'postcss-preset-env@7.8.2',
npm WARN EBADENGINE   required: { node: '^12 || ^14 || >=16' },
npm WARN EBADENGINE   current: { node: 'v15.14.0', npm: '7.7.6' }
npm WARN EBADENGINE }
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: 'postcss-pseudo-class-any-link@7.1.6',
npm WARN EBADENGINE   required: { node: '^12 || ^14 || >=16' },
npm WARN EBADENGINE   current: { node: 'v15.14.0', npm: '7.7.6' }
npm WARN EBADENGINE }
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: 'postcss-selector-not@6.0.1',
npm WARN EBADENGINE   required: { node: '^12 || ^14 || >=16' },
npm WARN EBADENGINE   current: { node: 'v15.14.0', npm: '7.7.6' }
npm WARN EBADENGINE }
npm WARN deprecated stable@0.1.8: Modern JS already guarantees Array#sort() is a stable sort, so this library is deprecated. See the compatibility table on MDN: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/sort#browser_compatibility
npm WARN deprecated text-encoding@0.6.4: no longer maintained
npm WARN deprecated ts-custom-error@2.2.2: npm package tarball contains useless codeclimate-reporter binary, please update to version 3.1.1. See https://github.com/adriengibrat/ts-custom-error/issues/32
npm notice 
npm notice New major version of npm available! 7.7.6 -> 8.19.2
npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.19.2>
npm notice Run `npm install -g npm@8.19.2` to update!
npm notice 
npm ERR! code ERR_SOCKET_TIMEOUT
npm ERR! errno ERR_SOCKET_TIMEOUT
npm ERR! request to https://registry.npmjs.org/@jest/types/-/types-28.1.3.tgz failed, reason: Socket timeout

npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2022-09-21T21_45_04_558Z-debug.log
Build cashtab-tests failed with exit code 1
emack added a subscriber: emack.
  • service-worker and serviceWorkerRegistration matches between patch and cra-template-pwa versions, ignoring the various linting deltas
  • confirmed no service works for the cra-template-pwa template and the existance of one with the patch version on netlify
This revision is now accepted and ready to land.Sep 22 2022, 13:16