Page MenuHomePhabricator

[avalanche] Fix abc_p2p_compactproofs flakiness
ClosedPublic

Authored by Fabien on Sep 21 2022, 15:58.

Details

Reviewers
sdulfari
Group Reviewers
Restricted Project
Commits
rABC195c3ef2605c: [avalanche] Fix abc_p2p_compactproofs flakiness
Summary

The loop waiting for the message count to increase is not reliable because the lock has to be released between the calls, so a message can sneak in between and cause a timeout on the next iteration.

This diff updates the test to use a more simple and robust approach.

Test Plan
./test/functional/test_runner.py abc_p2p_compactproofs

Diff Detail

Repository
rABC Bitcoin ABC
Branch
avalanche_fix_compactproof_test_flakiness
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 20108
Build 39903: Build Diffbuild-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 39902: arc lint + arc unit