Page MenuHomePhabricator
Differential D12030

logging: move checkpoint log into VALIDATION debug category
ClosedPublic
Actions

Authored by PiRK on Sep 22 2022, 08:51.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCb49e2448f7f0: logging: move checkpoint log into VALIDATION debug category
Summary

Checkpoint mismatch log messages are very common because of Bitcoin Cash and Bitcoin SV peers, and the word "ERROR" showing up just after starting a node confuses users.

Move these messages to a debug category.

Depends on D12043

Test Plan

ninja all check-all

Start bitcoind and verify for a few minutes that the error messages are no longer printed.

Run bitcoind -debug=VALIDATION and check that the error messages are logged.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Sep 22 2022, 08:51
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 22 2022, 08:51
PiRK requested review of this revision.Sep 22 2022, 08:51
Harbormaster completed remote builds in B20122: Diff 35103.Sep 22 2022, 09:09
PiRK planned changes to this revision.Sep 22 2022, 10:05

This is partially covered by core#23235, so let's backport this (and all dependencies) first, then rebase to apply only the remaining changes

PiRK updated this revision to Diff 35138.Sep 23 2022, 07:46
PiRK retitled this revision from logging: deduplicate checkpoint mismatch error messages and move them to BCLog::VALIDATION category to logging: move checkpoint log into VALIDATION debug category.
PiRK edited the summary of this revision. (Show Details)
PiRK edited the test plan for this revision. (Show Details)

rebase on top of D12043. Now this diff only moves two messages to the VALIDATION debug category.

PiRK edited the summary of this revision. (Show Details)Sep 23 2022, 07:47
PiRK added a parent revision: D12043: validation: put coins cache write log into bench debug log.
Fabien accepted this revision.Sep 23 2022, 08:28
This revision is now accepted and ready to land.Sep 23 2022, 08:28
PiRK added a child revision: D12044: add a release note for debug log changes.Sep 23 2022, 08:33
This revision was landed with ongoing or failed builds.Sep 23 2022, 08:49
Closed by commit rABCb49e2448f7f0: logging: move checkpoint log into VALIDATION debug category (authored by PiRK). · Explain Why
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCb49e2448f7f0: logging: move checkpoint log into VALIDATION debug category.
Harbormaster completed remote builds in B20144: Diff 35138.Sep 23 2022, 08:58

Revision Contents
Changeset List

PathSize
src/
12 lines

Diff 35151

View Options

src/validation.cpp

Loading...