Differential D12055

[Cashtab] Deprecate handleEncryptedOpReturn
ClosedPublic
Actions

Authored by emack on Sep 25 2022, 02:33.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABC5b612041d907: [Cashtab] Deprecate handleEncryptedOpReturn

Summary

Now that D12045 has landed there is no need for the handleEncryptedOpReturn() function as this is now part of sendXec().

Test Plan

npm test
grep -r 'handleEncryptedOpReturn' src/ and ensure no other uses for the function throughout cashtab
npm start
send and receive encrypted messages on an existing wallet
send and receive encrypted messages on a fresh new wallet

Diff Detail

Repository

rABC Bitcoin ABC

Branch

deprecateHandleEncryptedOpReturn

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20172
Build 40029: Build Diff	cashtab-tests
Build 40028: arc lint + arc unit

Event Timeline

emack created this revision.Sep 25 2022, 02:33

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 25 2022, 02:33

emack requested review of this revision.Sep 25 2022, 02:33

Harbormaster completed remote builds in B20172: Diff 35178.Sep 25 2022, 02:35

bytesofman accepted this revision.Sep 25 2022, 03:09

This revision is now accepted and ready to land.Sep 25 2022, 03:09

Closed by commit rABC5b612041d907: [Cashtab] Deprecate handleEncryptedOpReturn (authored by emack). · Explain WhySep 25 2022, 08:52

This revision was automatically updated to reflect the committed changes.

emack added a commit: rABC5b612041d907: [Cashtab] Deprecate handleEncryptedOpReturn.

Revision Contents
Changeset List

Path

Size

web/

cashtab/

src/

hooks/

__tests__/

useBCH.test.js

55 lines

useBCH.js

44 lines

Diff 35178

View Options

web/cashtab/src/hooks/tests/useBCH.test.js

View Options

web/cashtab/src/hooks/useBCH.js

[Cashtab] Deprecate handleEncryptedOpReturnClosedPublicActions