Differential D12061

[Cashtab] Comments in loadContactList should refer to contactList, not settings
ClosedPublic
Actions

Authored by kieran709 on Sep 26 2022, 17:59.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABC0fd427ad9498: [Cashtab] Comments in loadContactList should refer to contactList, not settings

Summary

Related to T2661. Comments in the loadContactList function in useWallet.js should refer to 'contactList' obj in local storage, not 'settings' obj.

Test Plan

navigate to web/cashtab/hooks/useWallet.js
find the loadContactList function
at lines 1089 & 1101, observe that the comments refer to the contactList obj in local storage

Diff Detail

Repository

rABC Bitcoin ABC

Branch

patch-comment-in-loadContactList

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20180
Build 40045: Build Diff	cashtab-tests
Build 40044: arc lint + arc unit

Event Timeline

kieran709 created this revision.Sep 26 2022, 17:59

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 26 2022, 17:59

kieran709 requested review of this revision.Sep 26 2022, 17:59

Harbormaster completed remote builds in B20180: Diff 35191.Sep 26 2022, 18:01

bytesofman accepted this revision.Sep 26 2022, 21:07

This revision is now accepted and ready to land.Sep 26 2022, 21:07

Closed by commit rABC0fd427ad9498: [Cashtab] Comments in loadContactList should refer to contactList, not settings (authored by kieran709). · Explain WhySep 27 2022, 14:05

This revision was automatically updated to reflect the committed changes.

kieran709 added a commit: rABC0fd427ad9498: [Cashtab] Comments in loadContactList should refer to contactList, not settings.

Revision Contents
Changeset List

Path

Size

web/

cashtab/

src/

hooks/

useWallet.js

4 lines

Diff 35191

View Options

web/cashtab/src/hooks/useWallet.js

[Cashtab] Comments in loadContactList should refer to contactList, not settingsClosedPublicActions