Paths

Table of Contentst

Differential D12068

refactor: Cleanup thread ctor calls
ClosedPublic
Actions

Authored by PiRK on Sep 27 2022, 08:37.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC950195631bd6: refactor: Cleanup thread ctor calls

Summary

refactor: Make TraceThread a non-template free function

Also it is moved into its own module.

refactor: Use appropriate thread constructor

refactor: Replace std::bind with lambdas

Lambdas are shorter and more readable.
Changes are limited to std::thread ctor calls only.

This is a backport of core#19064

Notes:

The mapport source file does not exist because we are missing core#18077
D11828 added an argument for CConnman::ThreadOpenConnections

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Sep 27 2022, 08:37

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 27 2022, 08:37

PiRK requested review of this revision.Sep 27 2022, 08:37

teamcity edited the summary of this revision. (Show Details)Sep 27 2022, 08:37

Harbormaster completed remote builds in B20192: Diff 35204.Sep 27 2022, 08:53

Fabien accepted this revision.Sep 27 2022, 09:49

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/init.cpp
2291 ↗	(On Diff #35204)

This revision is now accepted and ready to land.Sep 27 2022, 09:49

use address-of operator consistently instead of implicit function-to-pointer conversion

Harbormaster completed remote builds in B20193: Diff 35207.Sep 27 2022, 10:43

Closed by commit rABC950195631bd6: refactor: Cleanup thread ctor calls (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by PiRK). · Explain WhySep 27 2022, 14:32

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC950195631bd6: refactor: Cleanup thread ctor calls.

Revision Contents
Changeset List

Path

Size

src/

CMakeLists.txt

1 line

index/

base.cpp

6 lines

init.cpp

16 lines

net.cpp

40 lines

test/

util/

setup_common.cpp

8 lines

torcontrol.cpp

8 lines

txmempool.cpp

1 line

util/

system.h

19 lines

thread.h

18 lines

thread.cpp

27 lines

Diff 35219

View Options

src/CMakeLists.txt

View Options

src/index/base.cpp

View Options

src/init.cpp

View Options

src/net.cpp

View Options

src/test/util/setup_common.cpp

View Options

src/torcontrol.cpp

View Options

src/txmempool.cpp

View Options

src/util/system.h

View Options

src/util/thread.h

View Options

refactor: Cleanup thread ctor callsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 35219

src/CMakeLists.txt

src/index/base.cpp

src/init.cpp

src/net.cpp

src/test/util/setup_common.cpp

src/torcontrol.cpp

src/txmempool.cpp

src/util/system.h

src/util/thread.h

src/util/thread.cpp

refactor: Cleanup thread ctor calls
ClosedPublic
Actions

Revision Contents
Changeset List