Page MenuHomePhabricator

refactor: Cleanup thread ctor calls
ClosedPublic

Authored by PiRK on Sep 27 2022, 08:37.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC950195631bd6: refactor: Cleanup thread ctor calls
Summary

refactor: Make TraceThread a non-template free function

Also it is moved into its own module.

refactor: Use appropriate thread constructor

refactor: Replace std::bind with lambdas

Lambdas are shorter and more readable.
Changes are limited to std::thread ctor calls only.

This is a backport of core#19064

Notes:

  • The mapport source file does not exist because we are missing core#18077
  • D11828 added an argument for CConnman::ThreadOpenConnections
Test Plan

ninja all check-all

Event Timeline

PiRK requested review of this revision.Sep 27 2022, 08:37
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/init.cpp
2291 ↗(On Diff #35204)
This revision is now accepted and ready to land.Sep 27 2022, 09:49

use address-of operator consistently instead of implicit function-to-pointer conversion