Differential D12069

refactor: Move port mapping code to its own module
ClosedPublic
Actions

Authored by PiRK on Sep 27 2022, 12:42.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCc9dcb2b1b32f: refactor: Move port mapping code to its own module

Summary

This commit does not change behavior.

This is a backport of core#18077 [1/13]
https://github.com/bitcoin/bitcoin/pull/18077/commits/02ccf69dd6b772423acb343d16ef2bdbb3e3da03

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Sep 27 2022, 12:42

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 27 2022, 12:42

PiRK requested review of this revision.Sep 27 2022, 12:42

teamcity edited the summary of this revision. (Show Details)Sep 27 2022, 12:42

PiRK added a child revision: D12070: refactor: Replace magic number with named constant.Sep 27 2022, 12:45

Harbormaster completed remote builds in B20194: Diff 35208.Sep 27 2022, 12:59

Fabien accepted this revision.Sep 27 2022, 13:33

This revision is now accepted and ready to land.Sep 27 2022, 13:33

Closed by commit rABCc9dcb2b1b32f: refactor: Move port mapping code to its own module (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by PiRK). · Explain WhySep 28 2022, 06:05

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCc9dcb2b1b32f: refactor: Move port mapping code to its own module.

Revision Contents
Changeset List

Path

Size

src/

CMakeLists.txt

1 line

init.cpp

1 line

interfaces/

1 line

19 lines

141 lines

9 lines

117 lines

qt/

optionsmodel.cpp

1 line

Diff 35236

View Options

src/CMakeLists.txt

View Options

src/init.cpp

View Options

src/interfaces/node.cpp

View Options

src/mapport.h

View Options

src/mapport.cpp

View Options

src/net.h

View Options

src/net.cpp

View Options

refactor: Move port mapping code to its own moduleClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 35236

src/CMakeLists.txt

src/init.cpp

src/interfaces/node.cpp

src/mapport.h

src/mapport.cpp

src/net.h

src/net.cpp

src/qt/optionsmodel.cpp

refactor: Move port mapping code to its own module
ClosedPublic
Actions

Revision Contents
Changeset List