Differential D12078

Fix mismatching types for setDirtyBlockIndex
ClosedPublic
Actions

Authored by Fabien on Sep 27 2022, 19:10.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC5bb6c5912018: Fix mismatching types for setDirtyBlockIndex

Summary

The extern declaration and the definition don't match, triggering a -Wodr warning.
This issue was introduced in D12033.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

fix_setdirtyblockindex_constness

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20211
Build 40107: Build Diff	lint-circular-dependencies · build-diff · build-debug · build-without-wallet · build-clang · build-clang-tidy
Build 40106: arc lint + arc unit

Event Timeline

Fabien created this revision.Sep 27 2022, 19:10

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 27 2022, 19:10

Fabien requested review of this revision.Sep 27 2022, 19:10

PiRK accepted this revision.Sep 27 2022, 19:13

This revision is now accepted and ready to land.Sep 27 2022, 19:13

Harbormaster completed remote builds in B20211: Diff 35229.Sep 27 2022, 19:25

Closed by commit rABC5bb6c5912018: Fix mismatching types for setDirtyBlockIndex (authored by Fabien). · Explain WhySep 27 2022, 20:16

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC5bb6c5912018: Fix mismatching types for setDirtyBlockIndex.

Revision Contents
Changeset List

Path

Size

src/

node/

blockstorage.cpp

2 lines

Diff 35229

View Options

Fix mismatching types for setDirtyBlockIndexClosedPublicActions