Paths

Table of Contentst

Differential D1207

Explode disabled opcode if into a switch
ClosedPublic
Actions

Authored by deadalnix on Mar 17 2018, 01:26.

Details

Reviewers

schancel

Group Reviewers

Restricted Project

Commits

rSTAGING03b0d0c40e92: Explode disabled opcode if into a switch
rABC03b0d0c40e92: Explode disabled opcode if into a switch

Summary

This ensures that they can be manipulated one by one more easily.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

opcoderefac

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2128
Build 2400: Bitcoin ABC Buildbot (legacy)
Build 2399: arc lint + arc unit

Event Timeline

deadalnix created this revision.Mar 17 2018, 01:26

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 17 2018, 01:26

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2128: Diff 3249.Mar 17 2018, 02:06

schancel accepted this revision.Mar 17 2018, 02:24

This revision is now accepted and ready to land.Mar 17 2018, 02:24

schancel added inline comments.Mar 17 2018, 03:43

src/script/interpreter.cpp
336	We'll need another diff that splits this in two once the flag is actually checked; as they must still be disabled when the flag is off.

Closed by commit rABC03b0d0c40e92: Explode disabled opcode if into a switch (authored by deadalnix). · Explain WhyMar 17 2018, 08:39

This revision was automatically updated to reflect the committed changes.

deadalnix added inline comments.Mar 17 2018, 08:40

src/script/interpreter.cpp
336	Yes, it's just a matter of moving some `case` around.

Revision Contents
Changeset List

Path

Size

src/

script/

interpreter.cpp

32 lines

script.h

2 lines

Diff 3249

View Options

src/script/interpreter.cpp