Page MenuHomePhabricator

[avalanche] Fix a abc_feature_proof_cleanup potential failure
ClosedPublic

Authored by Fabien on Sep 28 2022, 07:56.

Details

Summary

The test expires the proof dangling timeout, then look at the log while elapsing the scheduler interval and expects the proofs to be removed. It can happen (https://build.bitcoinabc.org/viewLog.html?buildTypeId=BitcoinABC_BitcoinAbcStaging&buildId=440597&guest=1) that the scheduler runs after the timeout is elapsed but before the log is getting asserted, causing the test to fail. Elapsing the timeout after the log is read will prevent this.

Test Plan
./test/functional/test_runner.py abc_feature_proof_cleanup

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fix_abc_feature_proof_cleanup
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 20215
Build 40115: Build Diffbuild-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 40114: arc lint + arc unit