Page MenuHomePhabricator

[avalanche] Clarify the abc_p2p_compactproofs test
ClosedPublic

Authored by Fabien on Sep 28 2022, 09:12.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABCac50bfc9b7db: [avalanche] Clarify the abc_p2p_compactproofs test
Summary

A wild CI failure happened on this test (https://build.bitcoinabc.org/viewLog.html?buildTypeId=BitcoinABC_Master_BitcoinAbcMasterWOWallet&buildId=lastFinished&guest=1#testNameId-799256654276768243) when a message took just over 2s to appear in the logs, causing the assert_debug_log to fail on timeout. This is an opportunity to remove the log lookup entirely and clarify the intent of the test alltogether.

Test Plan
./test/functional/test_runner.py abc_p2p_compactproof

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fix_avalanche_p2p_compactproofs
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 20217
Build 40119: Build Diffbuild-without-wallet · build-diff · build-clang-tidy · build-debug · build-clang
Build 40118: arc lint + arc unit