[validation] explicit Success/Failure ctors for MempoolAcceptResult
ClosedPublic
Actions

Authored by PiRK on Sep 30 2022, 08:34.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC0b0ef2f57098: [validation] explicit Success/Failure ctors for MempoolAcceptResult

Summary

Makes code more clear and prevents accidentally calling the wrong ctor.

This is a backport of core#20833 [2/13]
https://github.com/bitcoin/bitcoin/pull/20833/commits/578148ded62828a9820398165c41670f4dbb523d

Depends on D12101

Commit backported out of order (standalone refactorings first, new feature last)

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Sep 30 2022, 08:34

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 30 2022, 08:34

PiRK requested review of this revision.Sep 30 2022, 08:34

teamcity edited the summary of this revision. (Show Details)Sep 30 2022, 08:34

Fabien edited the summary of this revision. (Show Details)Sep 30 2022, 08:44

Harbormaster completed remote builds in B20266: Diff 35316.Sep 30 2022, 08:59

Fabien accepted this revision.Sep 30 2022, 09:12

This revision is now accepted and ready to land.Sep 30 2022, 09:12

Closed by commit rABC0b0ef2f57098: [validation] explicit Success/Failure ctors for MempoolAcceptResult (authored by glozow <gzhao408@berkeley.edu>, committed by PiRK). · Explain WhySep 30 2022, 11:21

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC0b0ef2f57098: [validation] explicit Success/Failure ctors for MempoolAcceptResult.

Revision Contents
Changeset List

Path

Size

src/

validation.h

15 lines

validation.cpp

10 lines

Diff 35319

View Options

src/validation.h