Page MenuHomePhabricator
Differential D1213

Attempt to add json tests for BIN2NUM and NUM2BIN, but blocked by various bugs. This diff contains a few fixes to said bugs, but doesn't solve the entire picture.
AbandonedPublic
Actions

Authored by schancel on Mar 18 2018, 07:20.

Details

Reviewers
deadalnix
shadders
jasonbcox
Group Reviewers
Restricted Project
Summary

Working on top of D1103. Attempts to fix various bugs.

Test Plan

make check, but this fails currently

Diff Detail

Repository
rABC Bitcoin ABC
Branch
arcpatch-D1103
Lint
Lint Passed
SeverityLocationCodeMessage
Auto-Fixsrc/test/script_tests.cpp:1CFMTCode style violation
Unit
No Test Coverage
Build Status
Buildable 2156
Build 2456: Bitcoin ABC Buildbot (legacy)
Build 2455: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Mar 18 2018, 07:20
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 18 2018, 07:20
teamcity added a subscriber: teamcity.Mar 18 2018, 07:21

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

jasonbcox added inline comments.Mar 18 2018, 07:21
src/script/interpreter.cpp
1254

Try catch probably not needed, but seeing as CScriptNum can throw exceptions out of the constructor, it might be necessary. If so, it may be necessary all over this file.

teamcity added a comment.Mar 18 2018, 07:37

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging failed.

Harbormaster failed remote builds in B2156: Diff 3280!Mar 18 2018, 07:38
schancel commandeered this revision.Mar 18 2018, 09:03
schancel edited reviewers, added: jasonbcox; removed: schancel.
schancel abandoned this revision.Mar 18 2018, 10:56

Revision Contents
Changeset List

PathSize
src/
script/
20 lines
test/
data/
16 lines
2 lines

Diff 3280

View Options

src/script/interpreter.cpp

Loading...
View Options

src/test/data/script_tests.json

Loading...
View Options

src/test/script_tests.cpp

Loading...