Differential D12138

Refactor & improve makeseeds
ClosedPublic
Actions

Authored by sdulfari on Oct 4 2022, 17:48.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC93df28c6574f: Refactor & improve makeseeds

Summary

Backport of core#16999
This patch allows for an increased number of ipv6 seeds to be recorded by automation infra and unlocks further backports for improving makeseeds in the future.

https://github.com/bitcoin/bitcoin/pull/16999/commits/301c2b1ab594c483b698fa7c3f1ed8932af0554c (improve logging and filtering)
https://github.com/bitcoin/bitcoin/pull/16999/commits/3314d879666beaa1aa724ff28ad15326167e548f (factor out ASN lookup)
https://github.com/bitcoin/bitcoin/pull/16999/commits/c254a9ef692190342aa697e2c778d90091865e95 (dedup by ip, port)
https://github.com/bitcoin/bitcoin/pull/16999/commits/ed76299bea3e067cbc835fe50ce05ea1720d61c1 (limit per network)
https://github.com/bitcoin/bitcoin/pull/16999/commits/801d341f3a4b00633aa135407752d21ba868e37b (more fancy output)

Test Plan

python3 makeseeds.py < seeds_main.txt > nodes_main.txt
python3 makeseeds.py < seeds_test.txt > nodes_test.txt
git diff

Diff should be more additions than removals and retain most of the old entries.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

sdulfari created this revision.Oct 4 2022, 17:48

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 4 2022, 17:48

sdulfari requested review of this revision.Oct 4 2022, 17:48

teamcity edited the summary of this revision. (Show Details)Oct 4 2022, 17:48

Harbormaster completed remote builds in B20339: Diff 35410.Oct 4 2022, 17:48

Fabien accepted this revision.Oct 4 2022, 18:20

Fabien added a subscriber: Fabien.

Fabien added inline comments.

contrib/seeds/makeseeds.py
170–171 ↗	(On Diff #35410)	extra newlines
218 ↗	(On Diff #35410)
237 ↗	(On Diff #35410)	Unrelated but that's actually pretty low and might benefit from a bump