Page MenuHomePhabricator
Differential D12138

Refactor & improve makeseeds
ClosedPublic
Actions

Authored by sdulfari on Oct 4 2022, 17:48.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC93df28c6574f: Refactor & improve makeseeds
Summary

Backport of core#16999
This patch allows for an increased number of ipv6 seeds to be recorded by automation infra and unlocks further backports for improving makeseeds in the future.

https://github.com/bitcoin/bitcoin/pull/16999/commits/301c2b1ab594c483b698fa7c3f1ed8932af0554c (improve logging and filtering)
https://github.com/bitcoin/bitcoin/pull/16999/commits/3314d879666beaa1aa724ff28ad15326167e548f (factor out ASN lookup)
https://github.com/bitcoin/bitcoin/pull/16999/commits/c254a9ef692190342aa697e2c778d90091865e95 (dedup by ip, port)
https://github.com/bitcoin/bitcoin/pull/16999/commits/ed76299bea3e067cbc835fe50ce05ea1720d61c1 (limit per network)
https://github.com/bitcoin/bitcoin/pull/16999/commits/801d341f3a4b00633aa135407752d21ba868e37b (more fancy output)

Test Plan
python3 makeseeds.py < seeds_main.txt > nodes_main.txt
python3 makeseeds.py < seeds_test.txt > nodes_test.txt
git diff

Diff should be more additions than removals and retain most of the old entries.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr16999
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 20339
Build 40351: Build Diff
Build 40350: arc lint + arc unit

Event Timeline

sdulfari created this revision.Oct 4 2022, 17:48
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 4 2022, 17:48
sdulfari requested review of this revision.Oct 4 2022, 17:48
teamcity edited the summary of this revision. (Show Details)Oct 4 2022, 17:48
Harbormaster completed remote builds in B20339: Diff 35410.Oct 4 2022, 17:48
Fabien accepted this revision.Oct 4 2022, 18:20
Fabien added a subscriber: Fabien.
Fabien added inline comments.
contrib/seeds/makeseeds.py
170–171

extra newlines

218
237

Unrelated but that's actually pretty low and might benefit from a bump

This revision is now accepted and ready to land.Oct 4 2022, 18:20
sdulfari updated this revision to Diff 35415.Oct 4 2022, 18:24

Fix typo

Harbormaster completed remote builds in B20344: Diff 35415.Oct 4 2022, 18:24
sdulfari added inline comments.Oct 4 2022, 18:24
contrib/seeds/makeseeds.py
170–171

The linter adds these lines back

237

Yes, this seems too low.

Closed by commit rABC93df28c6574f: Refactor & improve makeseeds (authored by Wladimir J. van der Laan <laanwj@protonmail.com>, committed by sdulfari). · Explain WhyOct 4 2022, 18:26
This revision was automatically updated to reflect the committed changes.
sdulfari added a commit: rABC93df28c6574f: Refactor & improve makeseeds.

Revision Contents
Changeset List

PathSize
contrib/
seeds/
142 lines

Diff 35410

View Options

contrib/seeds/makeseeds.py

Loading...