Page MenuHomePhabricator

Refactor & improve makeseeds
ClosedPublic

Authored by sdulfari on Oct 4 2022, 17:48.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC93df28c6574f: Refactor & improve makeseeds
Summary
Test Plan
python3 makeseeds.py < seeds_main.txt > nodes_main.txt
python3 makeseeds.py < seeds_test.txt > nodes_test.txt
git diff

Diff should be more additions than removals and retain most of the old entries.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr16999
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 20344
Build 40361: Build Diff
Build 40360: arc lint + arc unit

Event Timeline

sdulfari requested review of this revision.Oct 4 2022, 17:48
Fabien added a subscriber: Fabien.
Fabien added inline comments.
contrib/seeds/makeseeds.py
170–171 ↗(On Diff #35410)

extra newlines

218 ↗(On Diff #35410)
237 ↗(On Diff #35410)

Unrelated but that's actually pretty low and might benefit from a bump

This revision is now accepted and ready to land.Oct 4 2022, 18:20
contrib/seeds/makeseeds.py
170–171 ↗(On Diff #35410)

The linter adds these lines back

237 ↗(On Diff #35410)

Yes, this seems too low.

This revision was automatically updated to reflect the committed changes.