Paths

Table of Contentst

Differential D12149

h}
ClosedPublic
Actions

Authored by PiRK on Oct 5 2022, 07:32.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC6a8b24f17db9: Move Hashers to util/hasher.{cpp/h}

Summary

Move the hashers that we use for hash tables to a common place.

Moved hashers:

SaltedTxidHasher
SaltedOutpointHasher
FilterHeaderHasher
SignatureCacheHasher
BlockHasher

Backport of core#19335 [1/3]
https://github.com/bitcoin/bitcoin/pull/19935/commits/95e61c1cf2a91d041c8025306ba36f0ea2806894

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20357
Build 40387: Build Diff	lint-circular-dependencies · build-debug · build-without-wallet · build-diff · build-clang · build-clang-tidy
Build 40386: arc lint + arc unit

Event Timeline

PiRK created this revision.Oct 5 2022, 07:32

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 5 2022, 07:32

PiRK requested review of this revision.Oct 5 2022, 07:32

teamcity edited the summary of this revision. (Show Details)Oct 5 2022, 07:32

PiRK added a child revision: D12150: Add generic SaltedSipHasher.Oct 5 2022, 07:33

I'm not sure if it is best to remove src/salteduint256hasher.[h|cpp] or keep it and include it in the new hasher.[h|cpp] source file.

For now, hasher.h does not seem to include too much stuff, so it is probably not a big impact to include it into files like peermanager.h.

Harbormaster completed remote builds in B20357: Diff 35436.Oct 5 2022, 07:48

Fabien accepted this revision.Oct 5 2022, 08:13

This revision is now accepted and ready to land.Oct 5 2022, 08:13

Closed by commit rABC6a8b24f17db9: Move Hashers to util/hasher.{cpp/h} (authored by Andrew Chow <achow101-github@achow101.com>, committed by PiRK). · Explain WhyOct 5 2022, 09:43

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC6a8b24f17db9: Move Hashers to util/hasher.{cpp/h}.

PiRK mentioned this in D12135: MOVEONLY: context-free package policies.Oct 5 2022, 09:47

Revision Contents
Changeset List

Path

Size

src/

CMakeLists.txt

2 lines

avalanche/

2 lines

1 line

2 lines

12 lines

32 lines

4 lines

index/

blockfilterindex.h

7 lines

salteduint256hasher.h

salteduint256hasher.cpp

script/

sigcache.h

21 lines

txmempool.h

9 lines

util/

hasher.h

101 lines

hasher.cpp

16 lines

validation.h

1 line

Diff 35436

View Options

src/CMakeLists.txt

View Options

src/avalanche/peermanager.h

View Options

src/avalanche/proof.h

View Options

src/avalanche/proofid.h

View Options

src/chain.h

View Options

src/coins.h

View Options

src/coins.cpp

View Options

src/index/blockfilterindex.h

View Options

src/salteduint256hasher.h

View Options

src/salteduint256hasher.cpp

View Options

src/script/sigcache.h

View Options

src/txmempool.h

View Options

src/util/hasher.h

View Options

src/util/hasher.cpp

View Options

Move Hashers to util/hasher.{cpp/h}ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 35436

src/CMakeLists.txt

src/avalanche/peermanager.h

src/avalanche/proof.h

src/avalanche/proofid.h

src/chain.h

src/coins.h

src/coins.cpp

src/index/blockfilterindex.h

src/salteduint256hasher.h

src/salteduint256hasher.cpp

src/script/sigcache.h

src/txmempool.h

src/util/hasher.h

src/util/hasher.cpp

src/validation.h

Move Hashers to util/hasher.{cpp/h}
ClosedPublic
Actions

Revision Contents
Changeset List