Page MenuHomePhabricator
Differential D12153

[test framework] simplify bytes to hex encoding
ClosedPublic
Actions

Authored by PiRK on Oct 5 2022, 14:28.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCb372159a97c6: [test framework] simplify bytes to hex encoding
Summary

Since Python 3.5, byte objects have a method for hex encoding.

Inspired by core#20916

Test Plan

ninja check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 5 2022, 14:28
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 5 2022, 14:28
PiRK requested review of this revision.Oct 5 2022, 14:28
teamcity edited the summary of this revision. (Show Details)Oct 5 2022, 14:28
Harbormaster completed remote builds in B20363: Diff 35443.Oct 5 2022, 14:40
Fabien requested changes to this revision.Oct 5 2022, 15:12
Fabien added a subscriber: Fabien.

That's not the right PR

This revision now requires changes to proceed.Oct 5 2022, 15:12
PiRK requested review of this revision.EditedOct 5 2022, 15:49
In D12153#272061, @Fabien wrote:

That's not the right PR

Yes, it is ;)

https://github.com/bitcoin/bitcoin/pull/20916/commits/fa0aa87071eaec8a5df17774cdb352195e5e09de#diff-1698fabd4ddd298eb28e234d97f34e744f568852b77361384c8edb38819de5e3R585

Everything else in that PR is not applicable.

Fabien accepted this revision.Oct 5 2022, 16:24
This revision is now accepted and ready to land.Oct 5 2022, 16:24
Closed by commit rABCb372159a97c6: [test framework] simplify bytes to hex encoding (authored by PiRK). · Explain WhyOct 5 2022, 16:25
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCb372159a97c6: [test framework] simplify bytes to hex encoding.

Revision Contents
Changeset List

PathSize
test/
functional/
test_framework/
6 lines

Diff 35454

View Options

test/functional/test_framework/messages.py

Loading...