Page MenuHomePhabricator
Differential D12154

misc package validation doc improvements
ClosedPublic
Actions

Authored by PiRK on Oct 5 2022, 16:09.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC7feb87b47507: misc package validation doc improvements
Summary

This is a backport of core#21800 [1/9]
https://github.com/bitcoin/bitcoin/pull/21800/commits/f95bbf58aaf72aab8a9c5827b1f162f3b8ac38f4

Test Plan

proof-reading

Diff Detail

Event Timeline

PiRK created this revision.Oct 5 2022, 16:09
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 5 2022, 16:09
PiRK requested review of this revision.Oct 5 2022, 16:09
teamcity edited the summary of this revision. (Show Details)Oct 5 2022, 16:09
Harbormaster completed remote builds in B20364: Diff 35444.Oct 5 2022, 16:14
teamcity added a comment.Oct 5 2022, 16:15
Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.

Failed tests logs:

====== Bitcoin ABC functional tests: feature_utxo_set_hash.py ======

------- Stdout: -------
2022-10-05T16:14:01.668000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20221005_161148/feature_utxo_set_hash_162
2022-10-05T16:14:01.925000Z TestFramework (INFO): Test MuHash implementation consistency
2022-10-05T16:14:02.178000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 132, in main
    self.run_test()
  File "/work/test/functional/feature_utxo_set_hash.py", line 74, in run_test
    self.test_muhash_implementation()
  File "/work/test/functional/feature_utxo_set_hash.py", line 67, in test_muhash_implementation
    assert_equal(finalized[::-1].hex(), node_muhash)
  File "/work/test/functional/test_framework/util.py", line 61, in assert_equal
    raise AssertionError("not({})".format(" == ".join(str(arg)
AssertionError: not(60f6ba37480c70c935a8af2eff0db9f011e37d4042909e7962be87cf440e6c5f == 20555c8231ce568ac47de92b9c30e53e13d98b43755ade226f040293fa86c4bc)
2022-10-05T16:14:02.229000Z TestFramework (INFO): Stopping nodes
2022-10-05T16:14:02.481000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20221005_161148/feature_utxo_set_hash_162
2022-10-05T16:14:02.481000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20221005_161148/feature_utxo_set_hash_162/test_framework.log
2022-10-05T16:14:02.481000Z TestFramework (ERROR): 
2022-10-05T16:14:02.481000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20221005_161148/feature_utxo_set_hash_162' to consolidate all logs
2022-10-05T16:14:02.481000Z TestFramework (ERROR): 
2022-10-05T16:14:02.481000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-10-05T16:14:02.481000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-10-05T16:14:02.481000Z TestFramework (ERROR):

Each failure log is accessible here:
Bitcoin ABC functional tests: feature_utxo_set_hash.py

teamcity added a comment.Oct 5 2022, 16:23
Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Failed tests logs:

====== Bitcoin ABC functional tests: feature_utxo_set_hash.py ======

------- Stdout: -------
2022-10-05T16:16:45.307000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20221005_161235/feature_utxo_set_hash_162
2022-10-05T16:16:45.615000Z TestFramework (INFO): Test MuHash implementation consistency
2022-10-05T16:16:45.879000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 132, in main
    self.run_test()
  File "/work/test/functional/feature_utxo_set_hash.py", line 74, in run_test
    self.test_muhash_implementation()
  File "/work/test/functional/feature_utxo_set_hash.py", line 67, in test_muhash_implementation
    assert_equal(finalized[::-1].hex(), node_muhash)
  File "/work/test/functional/test_framework/util.py", line 61, in assert_equal
    raise AssertionError("not({})".format(" == ".join(str(arg)
AssertionError: not(79ea4ff952daf94d59bcf92b10ea020afc10f7a4f2244872e8c73dab04470634 == 9b1b8fb9e59656a05da64c18638b54cdee42b2f1766efd56a9d6f4e42e3ac552)
2022-10-05T16:16:45.930000Z TestFramework (INFO): Stopping nodes
2022-10-05T16:16:46.182000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20221005_161235/feature_utxo_set_hash_162
2022-10-05T16:16:46.182000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20221005_161235/feature_utxo_set_hash_162/test_framework.log
2022-10-05T16:16:46.182000Z TestFramework (ERROR): 
2022-10-05T16:16:46.182000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20221005_161235/feature_utxo_set_hash_162' to consolidate all logs
2022-10-05T16:16:46.182000Z TestFramework (ERROR): 
2022-10-05T16:16:46.183000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-10-05T16:16:46.183000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-10-05T16:16:46.183000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests with the next upgrade activated: feature_utxo_set_hash.py ======

------- Stdout: -------
2022-10-05T16:20:49.181000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20221005_161659/feature_utxo_set_hash_162
2022-10-05T16:20:49.459000Z TestFramework (INFO): Test MuHash implementation consistency
2022-10-05T16:20:49.697000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 132, in main
    self.run_test()
  File "/work/test/functional/feature_utxo_set_hash.py", line 74, in run_test
    self.test_muhash_implementation()
  File "/work/test/functional/feature_utxo_set_hash.py", line 67, in test_muhash_implementation
    assert_equal(finalized[::-1].hex(), node_muhash)
  File "/work/test/functional/test_framework/util.py", line 61, in assert_equal
    raise AssertionError("not({})".format(" == ".join(str(arg)
AssertionError: not(8eec8196b178ad88a31c61c15e3b04743254d8fd86f93b76beabc950c830c98a == 999955231047b2da5a1b1438480fc7fd3f262308221e76cc47b4dcaeb26aacba)
2022-10-05T16:20:49.748000Z TestFramework (INFO): Stopping nodes
2022-10-05T16:20:50.050000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20221005_161659/feature_utxo_set_hash_162
2022-10-05T16:20:50.050000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20221005_161659/feature_utxo_set_hash_162/test_framework.log
2022-10-05T16:20:50.050000Z TestFramework (ERROR): 
2022-10-05T16:20:50.051000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20221005_161659/feature_utxo_set_hash_162' to consolidate all logs
2022-10-05T16:20:50.051000Z TestFramework (ERROR): 
2022-10-05T16:20:50.051000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-10-05T16:20:50.051000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-10-05T16:20:50.051000Z TestFramework (ERROR):

Each failure log is accessible here:
Bitcoin ABC functional tests: feature_utxo_set_hash.py
Bitcoin ABC functional tests with the next upgrade activated: feature_utxo_set_hash.py

teamcity added a comment.Oct 5 2022, 16:23
Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.

Failed tests logs:

====== Bitcoin ABC functional tests: feature_utxo_set_hash.py ======

------- Stdout: -------
2022-10-05T16:21:22.984000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20221005_161531/feature_utxo_set_hash_162
2022-10-05T16:21:23.542000Z TestFramework (INFO): Test MuHash implementation consistency
2022-10-05T16:21:24.081000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 132, in main
    self.run_test()
  File "/work/test/functional/feature_utxo_set_hash.py", line 74, in run_test
    self.test_muhash_implementation()
  File "/work/test/functional/feature_utxo_set_hash.py", line 67, in test_muhash_implementation
    assert_equal(finalized[::-1].hex(), node_muhash)
  File "/work/test/functional/test_framework/util.py", line 61, in assert_equal
    raise AssertionError("not({})".format(" == ".join(str(arg)
AssertionError: not(2dc9c947bc2e8d7f992df97859cdbf5f1afc42821b70eff52282050a85b6ed0a == 91531bdbc7c43b9bc25aefad82674118fcd96118fdc90559b0a1c04238ceb389)
2022-10-05T16:21:24.132000Z TestFramework (INFO): Stopping nodes
2022-10-05T16:21:24.333000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20221005_161531/feature_utxo_set_hash_162
2022-10-05T16:21:24.333000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20221005_161531/feature_utxo_set_hash_162/test_framework.log
2022-10-05T16:21:24.333000Z TestFramework (ERROR): 
2022-10-05T16:21:24.333000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20221005_161531/feature_utxo_set_hash_162' to consolidate all logs
2022-10-05T16:21:24.333000Z TestFramework (ERROR): 
2022-10-05T16:21:24.333000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-10-05T16:21:24.333000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-10-05T16:21:24.333000Z TestFramework (ERROR):

Each failure log is accessible here:
Bitcoin ABC functional tests: feature_utxo_set_hash.py

Fabien requested changes to this revision.Oct 5 2022, 16:24
Fabien added a subscriber: Fabien.

back to your queue

This revision now requires changes to proceed.Oct 5 2022, 16:24
PiRK updated this revision to Diff 35465.Oct 6 2022, 06:48

rebase

Harbormaster completed remote builds in B20375: Diff 35465.Oct 6 2022, 07:04
Fabien accepted this revision.Oct 6 2022, 07:12
This revision is now accepted and ready to land.Oct 6 2022, 07:12
Closed by commit rABC7feb87b47507: misc package validation doc improvements (authored by glozow <gloriajzhao@gmail.com>, committed by PiRK). · Explain WhyOct 6 2022, 11:19
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC7feb87b47507: misc package validation doc improvements.

Revision Contents
Changeset List

PathSize
src/
rpc/
4 lines
5 lines

Diff 35444

View Options

src/rpc/rawtransaction.cpp

Loading...
View Options

src/validation.h

Loading...