Page MenuHomePhabricator
Differential D12156

MOVEONLY: add helper function for calculating ancestors and checking limits
ClosedPublic
Actions

Authored by PiRK on Oct 5 2022, 16:13.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC62a017ade972: MOVEONLY: add helper function for calculating ancestors and checking limits
Summary

This is a backport of core#21800 [2/9]
https://github.com/bitcoin/bitcoin/pull/21800/commits/97dd1c729d2bbedf9527b914c0cc8267b8a7c21b

Test Plan

ninja all check-all

Diff Detail

Event Timeline

PiRK created this revision.Oct 5 2022, 16:13
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 5 2022, 16:13
PiRK requested review of this revision.Oct 5 2022, 16:13
teamcity edited the summary of this revision. (Show Details)Oct 5 2022, 16:13
PiRK planned changes to this revision.Oct 5 2022, 16:28

needs rebasing

Harbormaster completed remote builds in B20366: Diff 35448.Oct 5 2022, 16:51
teamcity added a comment.Oct 5 2022, 16:51
Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.

Failed tests logs:

====== Bitcoin ABC functional tests: feature_utxo_set_hash.py ======

------- Stdout: -------
2022-10-05T16:50:27.697000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20221005_164815/feature_utxo_set_hash_162
2022-10-05T16:50:27.954000Z TestFramework (INFO): Test MuHash implementation consistency
2022-10-05T16:50:28.184000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 132, in main
    self.run_test()
  File "/work/test/functional/feature_utxo_set_hash.py", line 74, in run_test
    self.test_muhash_implementation()
  File "/work/test/functional/feature_utxo_set_hash.py", line 67, in test_muhash_implementation
    assert_equal(finalized[::-1].hex(), node_muhash)
  File "/work/test/functional/test_framework/util.py", line 61, in assert_equal
    raise AssertionError("not({})".format(" == ".join(str(arg)
AssertionError: not(a8bfb47628028af69cb68c256082a3310c47b421b1537d609a8a673ad80af155 == 22e732d88585686b1d158b23b0921b68a999429ac04cd99a3831962ae2d06ea8)
2022-10-05T16:50:28.234000Z TestFramework (INFO): Stopping nodes
2022-10-05T16:50:28.386000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20221005_164815/feature_utxo_set_hash_162
2022-10-05T16:50:28.386000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20221005_164815/feature_utxo_set_hash_162/test_framework.log
2022-10-05T16:50:28.386000Z TestFramework (ERROR): 
2022-10-05T16:50:28.386000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20221005_164815/feature_utxo_set_hash_162' to consolidate all logs
2022-10-05T16:50:28.386000Z TestFramework (ERROR): 
2022-10-05T16:50:28.386000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-10-05T16:50:28.386000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-10-05T16:50:28.386000Z TestFramework (ERROR):

Each failure log is accessible here:
Bitcoin ABC functional tests: feature_utxo_set_hash.py

teamcity added a comment.Oct 5 2022, 16:54
Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.

Failed tests logs:

====== Bitcoin ABC functional tests: feature_utxo_set_hash.py ======

------- Stdout: -------
2022-10-05T16:52:26.290000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20221005_164642/feature_utxo_set_hash_162
2022-10-05T16:52:26.850000Z TestFramework (INFO): Test MuHash implementation consistency
2022-10-05T16:52:27.369000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 132, in main
    self.run_test()
  File "/work/test/functional/feature_utxo_set_hash.py", line 74, in run_test
    self.test_muhash_implementation()
  File "/work/test/functional/feature_utxo_set_hash.py", line 67, in test_muhash_implementation
    assert_equal(finalized[::-1].hex(), node_muhash)
  File "/work/test/functional/test_framework/util.py", line 61, in assert_equal
    raise AssertionError("not({})".format(" == ".join(str(arg)
AssertionError: not(a4bcd3b4677731a8ed28519ee332ffb9804f846e90f40d3f95e8907d697569a4 == d75f98664f55cb8014136a6e1d99e03e852f402c8e8caffe70e71bbe546ea539)
2022-10-05T16:52:27.420000Z TestFramework (INFO): Stopping nodes
2022-10-05T16:52:27.621000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20221005_164642/feature_utxo_set_hash_162
2022-10-05T16:52:27.621000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20221005_164642/feature_utxo_set_hash_162/test_framework.log
2022-10-05T16:52:27.621000Z TestFramework (ERROR): 
2022-10-05T16:52:27.621000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20221005_164642/feature_utxo_set_hash_162' to consolidate all logs
2022-10-05T16:52:27.621000Z TestFramework (ERROR): 
2022-10-05T16:52:27.621000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-10-05T16:52:27.621000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-10-05T16:52:27.621000Z TestFramework (ERROR):

Each failure log is accessible here:
Bitcoin ABC functional tests: feature_utxo_set_hash.py

teamcity added a comment.Oct 5 2022, 16:57
Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Failed tests logs:

====== Bitcoin ABC functional tests: feature_utxo_set_hash.py ======

------- Stdout: -------
2022-10-05T16:51:54.648000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20221005_164736/feature_utxo_set_hash_162
2022-10-05T16:51:54.983000Z TestFramework (INFO): Test MuHash implementation consistency
2022-10-05T16:51:55.224000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 132, in main
    self.run_test()
  File "/work/test/functional/feature_utxo_set_hash.py", line 74, in run_test
    self.test_muhash_implementation()
  File "/work/test/functional/feature_utxo_set_hash.py", line 67, in test_muhash_implementation
    assert_equal(finalized[::-1].hex(), node_muhash)
  File "/work/test/functional/test_framework/util.py", line 61, in assert_equal
    raise AssertionError("not({})".format(" == ".join(str(arg)
AssertionError: not(4f32ca1d03d77b7be85b2e339a85b86d5329f56f6501e0476675d6995b84062c == c385d1bfc2d937459708baed781731d274826297e7edb77b4c6be1c5feca7fd8)
2022-10-05T16:51:55.276000Z TestFramework (INFO): Stopping nodes
2022-10-05T16:51:55.530000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20221005_164736/feature_utxo_set_hash_162
2022-10-05T16:51:55.530000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20221005_164736/feature_utxo_set_hash_162/test_framework.log
2022-10-05T16:51:55.530000Z TestFramework (ERROR): 
2022-10-05T16:51:55.530000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20221005_164736/feature_utxo_set_hash_162' to consolidate all logs
2022-10-05T16:51:55.530000Z TestFramework (ERROR): 
2022-10-05T16:51:55.530000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-10-05T16:51:55.530000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-10-05T16:51:55.530000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests with the next upgrade activated: feature_utxo_set_hash.py ======

------- Stdout: -------
2022-10-05T16:55:57.912000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20221005_165210/feature_utxo_set_hash_162
2022-10-05T16:55:58.188000Z TestFramework (INFO): Test MuHash implementation consistency
2022-10-05T16:55:58.431000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 132, in main
    self.run_test()
  File "/work/test/functional/feature_utxo_set_hash.py", line 74, in run_test
    self.test_muhash_implementation()
  File "/work/test/functional/feature_utxo_set_hash.py", line 67, in test_muhash_implementation
    assert_equal(finalized[::-1].hex(), node_muhash)
  File "/work/test/functional/test_framework/util.py", line 61, in assert_equal
    raise AssertionError("not({})".format(" == ".join(str(arg)
AssertionError: not(03fd35f471c5f5da98552cd4f31dc54eaf4ce6deead76b5b76823b8e31afe2ba == 3962149e21515329e4e5711479a913ae715b91ca34123824f80b616f4414cd38)
2022-10-05T16:55:58.482000Z TestFramework (INFO): Stopping nodes
2022-10-05T16:55:58.733000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20221005_165210/feature_utxo_set_hash_162
2022-10-05T16:55:58.733000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20221005_165210/feature_utxo_set_hash_162/test_framework.log
2022-10-05T16:55:58.733000Z TestFramework (ERROR): 
2022-10-05T16:55:58.733000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20221005_165210/feature_utxo_set_hash_162' to consolidate all logs
2022-10-05T16:55:58.734000Z TestFramework (ERROR): 
2022-10-05T16:55:58.734000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-10-05T16:55:58.734000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-10-05T16:55:58.734000Z TestFramework (ERROR):

Each failure log is accessible here:
Bitcoin ABC functional tests: feature_utxo_set_hash.py
Bitcoin ABC functional tests with the next upgrade activated: feature_utxo_set_hash.py

PiRK updated this revision to Diff 35467.Oct 6 2022, 06:49

rebase

Harbormaster completed remote builds in B20377: Diff 35467.Oct 6 2022, 07:20
Fabien accepted this revision.Oct 6 2022, 08:00
This revision is now accepted and ready to land.Oct 6 2022, 08:00
Closed by commit rABC62a017ade972: MOVEONLY: add helper function for calculating ancestors and checking limits (authored by glozow <gloriajzhao@gmail.com>, committed by PiRK). · Explain WhyOct 6 2022, 11:19
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC62a017ade972: MOVEONLY: add helper function for calculating ancestors and checking limits.

Revision Contents
Changeset List

PathSize
src/
14 lines
73 lines

Diff 35448

View Options

src/txmempool.h

Loading...
View Options

src/txmempool.cpp

Loading...