Page MenuHomePhabricator

[Cashtab] Patch issue with burn all of a token locking UI
ClosedPublic

Authored by bytesofman on Oct 5 2022, 23:21.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABCfc4d566a78df: [Cashtab] Patch issue with burn all of a token locking UI
Summary

T2716

In the case of a burn token tx that burns all of a token balance, the useEffect loop that unlocks the UI was not being hit. Add a simple conditional which catches this case.

Test Plan

npm start
Burn all of a token and note that UI unlocks at same time app redirects to home
Burn some of a token and observe UI unlock functions as expected
Send some of a token and observe UI unlock functions as expected

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fix-etoken-burn-lock
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 20374
Build 40421: Build Diffcashtab-tests
Build 40420: arc lint + arc unit

Event Timeline

emack requested changes to this revision.Oct 5 2022, 23:55
emack added a subscriber: emack.

The full token balance burn issue is resolved however I noticed an edge case where sending etokens to the same etoken address it is being sent from will trigger a similar continuous loading process, however in this case it doesn't send it at all. This is reproducible in prod as well.

This revision now requires changes to proceed.Oct 5 2022, 23:55

The full token balance burn issue is resolved however I noticed an edge case where sending etokens to the same etoken address it is being sent from will trigger a similar continuous loading process, however in this case it doesn't send it at all. This is reproducible in prod as well.

I've created T2719 to handle this. If this issue currently exists at cashtab.com and is not introduced by this diff, then it should be resolved in its own diff.

This revision is now accepted and ready to land.Oct 6 2022, 03:13