Page MenuHomePhabricator

[Cashtab] Fix Reply button not showing
AbandonedPublic

Authored by kieran709 on Oct 6 2022, 14:33.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Summary

Related to T2712. Fixed issue with reply button not showing up, default behavior is now to show reply button on any OPReturnMsg tx.

Test Plan

cd web/cashtab && npm start
Ensure there are msg txs in recent TxHistory
Observe that the reply button is present on all msg txs
Navigate to settings page
Turn on hideMessagesFromUnknownSenders
navigate back to Home
Observe that the reply button is present on all msg txs.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
reply-button-not-showing-up
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 20382
Build 40437: Build Diffcashtab-tests
Build 40436: arc lint + arc unit

Event Timeline

Changed logic so that if hideMessagesFromUnkownSenders is on, the reply button will only appear on messages from non-contacts that have been expanded, and messages from contacts will display the reply button.

bytesofman requested changes to this revision.Oct 6 2022, 15:10

Need to implement this on latest master, might be easier to restart vs patch the conflicts as tx.js was changed extensively by chronik implementation in tx history

This revision now requires changes to proceed.Oct 6 2022, 15:10