Differential D12176

[avalanche] Cleanup the proof voting test
ClosedPublic
Actions

Authored by Fabien on Oct 7 2022, 13:59.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC696d5d33e28b: [avalanche] Cleanup the proof voting test

Summary

Remove dangling log
Remove duplicated test case
Remove duplicated peer
Remove the wait_for_disconnect and whitelist the locahost. This leads to a minor duration gain which will turn huge in the next diff.

Test Plan

./test/functional/test_runner.py abc_p2p_avalanche_proof_voting

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avalanche_cleanup_proof_voting_test

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20401
Build 40475: Build Diff	build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 40474: arc lint + arc unit

Event Timeline

Fabien created this revision.Oct 7 2022, 13:59

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 7 2022, 13:59

Fabien requested review of this revision.Oct 7 2022, 13:59

Harbormaster completed remote builds in B20401: Diff 35528.Oct 7 2022, 14:18

Fabien added a child revision: D12177: [avalanche] Avoid connecting via addavalanchenode in tests.Oct 7 2022, 15:36

sdulfari accepted this revision.Oct 7 2022, 23:37

This revision is now accepted and ready to land.Oct 7 2022, 23:37

Closed by commit rABC696d5d33e28b: [avalanche] Cleanup the proof voting test (authored by Fabien). · Explain WhyOct 8 2022, 21:36

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC696d5d33e28b: [avalanche] Cleanup the proof voting test.

Revision Contents
Changeset List

Path

Size

test/

functional/

abc_p2p_avalanche_proof_voting.py

21 lines

Diff 35528

test/functional/abc_p2p_avalanche_proof_voting.py

Loading...