HomePhabricator

[refactor] pass coinsview and height to check()

Description

[refactor] pass coinsview and height to check()

Summary:
Removes check's dependency on validation.h. This is a step towards removing the txmempool --> validation circular dependency.

From the PR's description:

There are two functions in txmempool that need validation right now: check() and removeForReorg(). This PR removes the dependencies in check().

This concludes backport of core#23157 [8/8]
https://github.com/bitcoin/bitcoin/pull/23157/commits/082c5bf099c64e3d27abe9b68a71ce500b693e7e#diff-6875de769e90cec84d2e8a9c1b962cdbcda44d870d42e4215827e599e11e90e3

Depends on D12173

The fuzzer change is not applicable due to missing backports.

Test Plan: ninja all check-all bench-bitcoin

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Subscribers: Fabien

Differential Revision: https://reviews.bitcoinabc.org/D12174

Details

Provenance
glozow <gloriajzhao@gmail.com>Authored on Sep 29 2021, 18:36
PiRKCommitted on Oct 7 2022, 13:38
PiRKPushed on Oct 7 2022, 13:39
Reviewer
Restricted Project
Differential Revision
D12174: [refactor] pass coinsview and height to check()
Parents
rABC654ce965298f: [mempool] simplify some check() logic
Branches
Unknown
Tags
Unknown