HomePhabricator

[mempool] simplify some check() logic

Description

[mempool] simplify some check() logic

Summary:
No transaction in the mempool should ever be a coinbase.

Since mempoolDuplicate's backend is the chainstate coins view, it should
always contain the coins available.

This is a backport of core#23157 [7/8]
https://github.com/bitcoin/bitcoin/pull/23157/commits/ed6115f1eae0eb4669601106a9aaff078a2f3a74

Depends on D12172

Test Plan: ninja all check-all

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D12173

Details

Provenance
glozow <gloriajzhao@gmail.com>Authored on Oct 4 2021, 11:58
PiRKCommitted on Oct 7 2022, 13:38
PiRKPushed on Oct 7 2022, 13:39
Reviewer
Restricted Project
Differential Revision
D12173: [mempool] simplify some check() logic
Parents
rABC12aa734d7c3e: [validation/mempool] use Spend/AddCoin instead of UpdateCoins
Branches
Unknown
Tags
Unknown