[mempool] simplify some check() logic
ClosedPublic
Actions

Authored by PiRK on Oct 7 2022, 09:25.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC654ce965298f: [mempool] simplify some check() logic

Summary

No transaction in the mempool should ever be a coinbase.

Since mempoolDuplicate's backend is the chainstate coins view, it should
always contain the coins available.

This is a backport of core#23157 [7/8]
https://github.com/bitcoin/bitcoin/pull/23157/commits/ed6115f1eae0eb4669601106a9aaff078a2f3a74

Depends on D12172

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 7 2022, 09:25

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 7 2022, 09:25

PiRK requested review of this revision.Oct 7 2022, 09:25

teamcity edited the summary of this revision. (Show Details)Oct 7 2022, 09:25

PiRK added a child revision: D12174: [refactor] pass coinsview and height to check().Oct 7 2022, 09:28

Harbormaster completed remote builds in B20396: Diff 35512.Oct 7 2022, 09:53

Fabien accepted this revision.Oct 7 2022, 10:18

This revision is now accepted and ready to land.Oct 7 2022, 10:18

Closed by commit rABC654ce965298f: [mempool] simplify some check() logic (authored by glozow <gloriajzhao@gmail.com>, committed by PiRK). · Explain WhyOct 7 2022, 13:39

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC654ce965298f: [mempool] simplify some check() logic.

Fabien mentioned this in D13133: mempool: Add topological index, enforce consistency, updated reorg logic.Feb 15 2023, 16:49

Fabien mentioned this in rABCeec0e0c7b0f0: mempool: Add topological index, enforce consistency, updated reorg logic.Feb 21 2023, 10:32

Revision Contents
Changeset List

Path

Size

src/

txmempool.cpp

20 lines

Diff 35526

View Options

[mempool] simplify some check() logicClosedPublicActions