Page MenuHomePhabricator
Differential D12188

[Cashtab] Remove unused imports useBCH.test.js
ClosedPublic
Actions

Authored by kieran709 on Oct 10 2022, 13:40.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABC5fa5f1098e02: [Cashtab] Remove unused imports useBCH.test.js
Summary

Removed unused imports from useBCH.test.js, related to T2714.

Test Plan

cd web/cashtab && npm start
navigate to cashtab/src/hooks/__tests__/useBCH.test.js
observe that there are no unused imports

npm test

all tests should pass

Diff Detail

Repository
rABC Bitcoin ABC
Branch
remove-unused-imports-useBCH-test
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 20583
Build 40836: Build Diffcashtab-tests
Build 40835: arc lint + arc unit

Event Timeline

kieran709 created this revision.Oct 10 2022, 13:40
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 10 2022, 13:40
kieran709 requested review of this revision.Oct 10 2022, 13:40
Harbormaster completed remote builds in B20421: Diff 35555.Oct 10 2022, 13:43
bytesofman requested changes to this revision.Oct 12 2022, 16:08

Looks good - please rebase as the recently landed diff removing getPublicKey functions had some impact to this file.

This revision now requires changes to proceed.Oct 12 2022, 16:08
kieran709 updated this revision to Diff 35799.Oct 18 2022, 14:23

Responding to review feedback, rebased & added test comment.

kieran709 updated this revision to Diff 35800.Oct 18 2022, 14:23

Removed test comment

Harbormaster completed remote builds in B20583: Diff 35799.Oct 18 2022, 14:39
Harbormaster completed remote builds in B20584: Diff 35800.
bytesofman accepted this revision.Oct 18 2022, 22:48
This revision is now accepted and ready to land.Oct 18 2022, 22:48
Closed by commit rABC5fa5f1098e02: [Cashtab] Remove unused imports useBCH.test.js (authored by kieran709). · Explain WhyOct 21 2022, 15:25
This revision was automatically updated to reflect the committed changes.
kieran709 added a commit: rABC5fa5f1098e02: [Cashtab] Remove unused imports useBCH.test.js.

Revision Contents
Changeset List

PathSize
web/
cashtab/
src/
hooks/
__tests__/
26 lines

Diff 35799

View Options

web/cashtab/src/hooks/__tests__/useBCH.test.js

Loading...