Differential D12195

[Cashtab][Pt1/2] Parse Airdrops in TxHistory
ClosedPublic
Actions

Authored by kieran709 on Oct 10 2022, 18:40.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABC63e90422e90b: [Cashtab][Pt1/2] Parse Airdrops in TxHistory

Summary

Related to T2415. Sent and Received airdrops now show the airdrop icon, along with the token icon. Pt 2 will add the token name from cashtabCache.

Test Plan

cd web/cashtab && npm start
if there are no sent and received airdrop txs in recent tx history, make them
observe that the Airdrop Icon shows for airdrop txs
observe that the eToken Icon shows for the related tx

Diff Detail

Repository

rABC Bitcoin ABC

Branch

parse-airdrops-tx-history

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20429
Build 40530: Build Diff	cashtab-tests
Build 40529: arc lint + arc unit

Event Timeline

kieran709 created this revision.Oct 10 2022, 18:40

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 10 2022, 18:40

kieran709 requested review of this revision.Oct 10 2022, 18:40

Harbormaster completed remote builds in B20429: Diff 35567.Oct 10 2022, 18:43

The "Received" or "Sent" text should instead read "Airdrop" for these txs

This revision now requires changes to proceed.Oct 11 2022, 16:33

bytesofman mentioned this in D12196: [Cashtab][Pt 2/2] Parse Airdrops in TxHistory - using cashtabCache to get airdrop token name.Oct 11 2022, 16:35

kieran709 added a child revision: D12196: [Cashtab][Pt 2/2] Parse Airdrops in TxHistory - using cashtabCache to get airdrop token name.Oct 18 2022, 14:39

Responding to review feedback.

Harbormaster completed remote builds in B20669: Diff 35941.Oct 21 2022, 16:10

bytesofman accepted this revision.Oct 24 2022, 17:49

This revision is now accepted and ready to land.Oct 24 2022, 17:49

Closed by commit rABC63e90422e90b: [Cashtab][Pt1/2] Parse Airdrops in TxHistory (authored by kieran709). · Explain WhyOct 26 2022, 16:24

This revision was automatically updated to reflect the committed changes.

kieran709 added a commit: rABC63e90422e90b: [Cashtab][Pt1/2] Parse Airdrops in TxHistory.

Revision Contents
Changeset List

Path

Size

web/

cashtab/

src/

components/

Home/

Tx.js

59 lines

__tests__/

__snapshots__/

Home.test.js.snap

Diff 35567

View Options

web/cashtab/src/components/Home/Tx.js

View Options

web/cashtab/src/components/Home/tests/snapshots/Home.test.js.snap

[Cashtab][Pt1/2] Parse Airdrops in TxHistoryClosedPublicActions