Page MenuHomePhabricator

Add support for BIN2NUM opcode

Authored by deadalnix on Mar 19 2018, 15:23.



As per title. As the whole number system is LE, I went went for LE encoding. This doesn't seems like a great idea to fubar the scrpipt system even more than it already is by introducing mixed endianess in it.

Test Plan

Added various test cases.

Diff Detail

rABC Bitcoin ABC
Lint Not Applicable
Tests Not Applicable

Event Timeline

jasonbcox requested changes to this revision.Mar 19 2018, 17:05
jasonbcox added subscribers: schancel, jasonbcox.

Couple nits, then I think we're good to go

355 ↗(On Diff #3312)

@schancel and I were hoping to split these tests up a bit. For BIN2NUM and NUM2BIN, please use monolith_opcodes_type.cpp (see

415 ↗(On Diff #3312)


418 ↗(On Diff #3312)

Mege -> Merge

This revision now requires changes to proceed.Mar 19 2018, 17:05
355 ↗(On Diff #3312)

There is already a ton of reundancy in that code, so we want to factor that out at some point. It'll be easier in one file.

415 ↗(On Diff #3312)

That's elite programming right there XD

Fix as per comment and rebase

This revision is now accepted and ready to land.Mar 19 2018, 17:26
This revision was automatically updated to reflect the committed changes.