Paths

Table of Contentst

Differential D12203

refactor: replace config with chain params in LoadMempool arguments
AbandonedPublic
Actions

Authored by PiRK on Oct 11 2022, 09:53.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Summary

The config is only used to access the chain params.

Depends on D12202

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20437
Build 40546: Build Diff	build-without-wallet · lint-circular-dependencies · build-diff · build-debug · build-clang-tidy · build-clang
Build 40545: arc lint + arc unit

Event Timeline

PiRK created this revision.Oct 11 2022, 09:53

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 11 2022, 09:53

PiRK requested review of this revision.Oct 11 2022, 09:53

PiRK added a child revision: D12198: refactor: remove more unused config argument.Oct 11 2022, 09:57

Harbormaster completed remote builds in B20437: Diff 35577.Oct 11 2022, 10:23

Fabien requested changes to this revision.Oct 11 2022, 14:31

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/validation.h
1406	See D12202

This revision now requires changes to proceed.Oct 11 2022, 14:31

done in D12214

PiRK removed a child revision: D12198: refactor: remove more unused config argument.Oct 14 2022, 07:37

PiRK removed a parent revision: D12202: refactor: remove config argument from removeForReorg and updateMempoolForReorg.Oct 14 2022, 07:42

Revision Contents
Changeset List

Path

Size

src/

node/

blockstorage.cpp

2 lines

validation.h

4 lines

validation.cpp

13 lines

Diff 35577

View Options

src/node/blockstorage.cpp

View Options

src/validation.h

View Options

refactor: replace config with chain params in LoadMempool argumentsAbandonedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 35577

src/node/blockstorage.cpp

src/validation.h

src/validation.cpp

refactor: replace config with chain params in LoadMempool arguments
AbandonedPublic
Actions

Revision Contents
Changeset List