Differential D12212

[avalanche] Fix tests flakiness with manual connections
ClosedPublic
Actions

Authored by Fabien on Oct 12 2022, 09:03.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCbd10cc7435b7: [avalanche] Fix tests flakiness with manual connections

Summary

On slow machines the node can see the connection to the test framework peers before the python network thread is marked as connected, causing the test to fail.

This diff fixes it byt waiting for the connection to be marked as established on the python side.

Fixes https://build.bitcoinabc.org/viewLog.html?buildId=447123&buildTypeId=BitcoinABC_Master_BitcoinAbcMasterWOWallet&tab=buildLog and
https://build.bitcoinabc.org/viewLog.html?buildId=449892&buildTypeId=BitcoinABC_Master_CrossBuilds_CrossBuildLinux32&tab=buildLog

Test Plan

./test/functional/test_runner.py abc_p2p_compactproofs abc_p2p_getavaaddr

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Oct 12 2022, 09:03

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 12 2022, 09:03

Fabien requested review of this revision.Oct 12 2022, 09:03

Harbormaster completed remote builds in B20448: Diff 35599.Oct 12 2022, 09:20

PiRK accepted this revision.Oct 12 2022, 11:24

This revision is now accepted and ready to land.Oct 12 2022, 11:24

Closed by commit rABCbd10cc7435b7: [avalanche] Fix tests flakiness with manual connections (authored by Fabien). · Explain WhyOct 12 2022, 11:57

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCbd10cc7435b7: [avalanche] Fix tests flakiness with manual connections.

Revision Contents
Changeset List

Path

Size

test/

functional/

abc_p2p_compactproofs.py

3 lines

abc_p2p_getavaaddr.py

3 lines

Diff 35611

View Options

test/functional/abc_p2p_compactproofs.py