HomePhabricator

[avalanche] Fix tests flakiness with manual connections

Description

[avalanche] Fix tests flakiness with manual connections

Summary:
On slow machines the node can see the connection to the test framework peers before the python network thread is marked as connected, causing the test to fail.

This diff fixes it byt waiting for the connection to be marked as established on the python side.

Fixes https://build.bitcoinabc.org/viewLog.html?buildId=447123&buildTypeId=BitcoinABC_Master_BitcoinAbcMasterWOWallet&tab=buildLog and
https://build.bitcoinabc.org/viewLog.html?buildId=449892&buildTypeId=BitcoinABC_Master_CrossBuilds_CrossBuildLinux32&tab=buildLog

Test Plan:

./test/functional/test_runner.py abc_p2p_compactproofs abc_p2p_getavaaddr

Reviewers: #bitcoin_abc, PiRK

Reviewed By: #bitcoin_abc, PiRK

Differential Revision: https://reviews.bitcoinabc.org/D12212

Details

Provenance
FabienAuthored on Oct 12 2022, 09:02
FabienPushed on Oct 12 2022, 11:57
Reviewer
Restricted Project
Differential Revision
D12212: [avalanche] Fix tests flakiness with manual connections
Parents
rABCd428d7e07577: test: Bump timeouts to avoid valgrind failures
Branches
Unknown
Tags
Unknown