Page MenuHomePhabricator

Implement support for NUM2BIN
ClosedPublic

Authored by deadalnix on Mar 21 2018, 05:38.

Details

Reviewers
schancel
Group Reviewers
Restricted Project
Maniphest Tasks
Restricted Maniphest Task
Commits
rSTAGINGa30ddaf208ab: Implement support for NUM2BIN
rABCa30ddaf208ab: Implement support for NUM2BIN
Summary

As per title.

Test Plan

Ass json test cases and unit tests.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jasonbcox requested changes to this revision.Mar 21 2018, 06:40
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/test/data/script_tests.json
836 ↗(On Diff #3320)

arguement -> argument for this and the other tests below

847 ↗(On Diff #3320)

Needs a case for negative zero:
["-0 1", "NUM2BIN 0x00 EQUAL", "P2SH,STRICTENC,MONOLITH_OPCODES", "OK", "Negative zero extended as zero"],

This revision now requires changes to proceed.Mar 21 2018, 06:40
  • arguement
  • negative zero
This revision is now accepted and ready to land.Mar 22 2018, 04:50
schancel added a task: Restricted Maniphest Task.Mar 22 2018, 04:55
This revision was automatically updated to reflect the committed changes.