Differential D12246

[net] Construct addrman outside connman
ClosedPublic
Actions

Authored by Fabien on Oct 14 2022, 12:09.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC94248d17e3cf: [net] Construct addrman outside connman

Summary

 node.context owns the CAddrMan. CConnman holds a reference to
the CAddrMan.

Partial backport of core#20228:
https://github.com/bitcoin/bitcoin/pull/20228/commits/1c25adf6d278eb1a1f018986a126d0eb8137e0ee

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Oct 14 2022, 12:09

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 14 2022, 12:09

Fabien requested review of this revision.Oct 14 2022, 12:09

teamcity edited the summary of this revision. (Show Details)Oct 14 2022, 12:09

Fabien added a child revision: D12247: [net_processing] Keep addrman reference in PeerManager.Oct 14 2022, 12:10

Harbormaster completed remote builds in B20507: Diff 35686.Oct 14 2022, 12:24

PiRK accepted this revision.Oct 14 2022, 13:29

This revision is now accepted and ready to land.Oct 14 2022, 13:29

Closed by commit rABC94248d17e3cf: [net] Construct addrman outside connman (authored by John Newbery <john@johnnewbery.com>, committed by Fabien). · Explain WhyOct 14 2022, 13:48

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC94248d17e3cf: [net] Construct addrman outside connman.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

test/

3 lines

5 lines

4 lines

5 lines

node/

context.h

2 lines

context.cpp

1 line

test/

denialofservice_tests.cpp

12 lines

net_tests.cpp

11 lines

util/

setup_common.cpp

6 lines

Diff 35696

View Options

src/avalanche/test/processor_tests.cpp

View Options

src/init.cpp

View Options

src/net.h

View Options

src/net.cpp

View Options

src/node/context.h

View Options

src/node/context.cpp

View Options

src/test/denialofservice_tests.cpp

View Options

src/test/net_tests.cpp

View Options

src/test/util/setup_common.cpp

[net] Construct addrman outside connmanClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 35696

src/avalanche/test/processor_tests.cpp

src/init.cpp

src/net.h

src/net.cpp

src/node/context.h

src/node/context.cpp

src/test/denialofservice_tests.cpp

src/test/net_tests.cpp

src/test/util/setup_common.cpp

[net] Construct addrman outside connman
ClosedPublic
Actions

Revision Contents
Changeset List