Differential D12261

[Cashtab] Deprecate API wrapper - signPkMessage
ClosedPublic
Actions

Authored by emack on Oct 15 2022, 14:45.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABC649e2b3dce3c: [Cashtab] Deprecate API wrapper - signPkMessage

Summary

As per T2370, deprecating signPkMessage as it was just an API wrapper.

Test Plan

sign a message, note the signature, message and address, then verify this matches via the verify message function.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

deprecateSignPkMsg

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20533
Build 40737: Build Diff	cashtab-tests
Build 40736: arc lint + arc unit

Event Timeline

emack created this revision.Oct 15 2022, 14:45

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 15 2022, 14:45

emack requested review of this revision.Oct 15 2022, 14:45

Harbormaster completed remote builds in B20533: Diff 35723.Oct 15 2022, 14:48

bytesofman accepted this revision.Oct 18 2022, 22:42

This revision is now accepted and ready to land.Oct 18 2022, 22:42

Closed by commit rABC649e2b3dce3c: [Cashtab] Deprecate API wrapper - signPkMessage (authored by emack). · Explain WhyOct 19 2022, 01:46

This revision was automatically updated to reflect the committed changes.

emack added a commit: rABC649e2b3dce3c: [Cashtab] Deprecate API wrapper - signPkMessage.

Revision Contents
Changeset List

Path

Size

web/

cashtab/

src/

components/

Send/

Send.js

12 lines

hooks/

useBCH.js

14 lines

Diff 35723

View Options

web/cashtab/src/components/Send/Send.js