Differential D12265

refactor: Mark CAddrMan::Select and GetAddr const
ClosedPublic
Actions

Authored by Fabien on Oct 17 2022, 08:03.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCe3d8b59d5e68: refactor: Mark CAddrMan::Select and GetAddr const

Summary

To clarify that a call to this only changes the random state and nothing else.

Backport of core#21940.

The source material does more that what the title says, but only the 2 first commits are relevant to our codebase, making it actually accurate:

This is due to the fact that we didn't backport the fuzzer yet, and the addrman deterministic behavior has been changed in D11827 and the locks properly held in the previous backports.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Oct 17 2022, 08:03

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 17 2022, 08:03

Fabien requested review of this revision.Oct 17 2022, 08:03

teamcity edited the summary of this revision. (Show Details)Oct 17 2022, 08:03

Harbormaster completed remote builds in B20538: Diff 35733.Oct 17 2022, 08:41

PiRK accepted this revision.Oct 17 2022, 08:43

This revision is now accepted and ready to land.Oct 17 2022, 08:43

Closed by commit rABCe3d8b59d5e68: refactor: Mark CAddrMan::Select and GetAddr const (authored by MarcoFalke <falke.marco@gmail.com>, committed by Fabien). · Explain WhyOct 17 2022, 09:58

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCe3d8b59d5e68: refactor: Mark CAddrMan::Select and GetAddr const.

Revision Contents
Changeset List

Path

Size

src/

addrman.h

30 lines

addrman.cpp

31 lines

Diff 35740

View Options

src/addrman.h