HomePhabricator

refactor: Mark CAddrMan::Select and GetAddr const

Description

refactor: Mark CAddrMan::Select and GetAddr const

Summary:

To clarify that a call to this only changes the random state and nothing else.

Backport of core#21940.

The source material does more that what the title says, but only the 2 first commits are relevant to our codebase, making it actually accurate:

This is due to the fact that we didn't backport the fuzzer yet, and the addrman deterministic behavior has been changed in D11827 and the locks properly held in the previous backports.

Test Plan:

ninja all check-all

Reviewers: #bitcoin_abc, PiRK

Reviewed By: #bitcoin_abc, PiRK

Differential Revision: https://reviews.bitcoinabc.org/D12265

Details

Provenance
MarcoFalke <falke.marco@gmail.com>Authored on May 13 2021, 10:13
FabienCommitted on Oct 17 2022, 09:58
FabienPushed on Oct 17 2022, 09:58
Reviewer
Restricted Project
Differential Revision
D12265: refactor: Mark CAddrMan::Select and GetAddr const
Parents
rABC10ea90c31dfa: Remove txindex migration code
Branches
Unknown
Tags
Unknown