test: refactor: separate CreateBlock in TestChain100Setup
ClosedPublic
Actions

Authored by PiRK on Oct 17 2022, 08:34.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC954fc7392543: test: refactor: separate CreateBlock in TestChain100Setup

Summary

This is so we can create blocks within unittests and have them
be processed by specific chainstates (instead of the just the
active one).

This is a backport of core#21526 [11/12]
https://github.com/bitcoin/bitcoin/pull/21526/commits/2705570109a2a90ecfd3f4180944498626fc2707#

Test Plan

ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 17 2022, 08:34

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 17 2022, 08:34

PiRK requested review of this revision.Oct 17 2022, 08:34

teamcity edited the summary of this revision. (Show Details)Oct 17 2022, 08:34

Harbormaster completed remote builds in B20542: Diff 35737.Oct 17 2022, 09:10

Fabien accepted this revision.Oct 17 2022, 10:13

This revision is now accepted and ready to land.Oct 17 2022, 10:13

Closed by commit rABC954fc7392543: test: refactor: separate CreateBlock in TestChain100Setup (authored by James O'Beirne <james.obeirne@pm.me>, committed by PiRK). · Explain WhyOct 17 2022, 14:51

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC954fc7392543: test: refactor: separate CreateBlock in TestChain100Setup.

Revision Contents
Changeset List

Path

Size

src/

test/

util/

setup_common.h

12 lines

setup_common.cpp

26 lines

Diff 35757

View Options

src/test/util/setup_common.h